Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correlation matrix example does not work. #29

Open
TheChymera opened this issue Jul 10, 2017 · 2 comments
Open

Correlation matrix example does not work. #29

TheChymera opened this issue Jul 10, 2017 · 2 comments
Assignees

Comments

@TheChymera
Copy link
Member

TheChymera commented Jul 10, 2017

The recently contributed correlation matrix function seems to not work properly. It produces the following plot:

figure_1

Not least of all, it took a bit of fixing to get it to even execute, in the future, please try to:

  • import needed functions 903e227
  • handle plausible input type possibilities in the appropriate fashion 2374dda
  • indent with tabs 23cb4db
@TheChymera
Copy link
Member Author

Also, while it is cool that the correlation matrix function can save the data file for later plotting, ideally we would not do this in any example (to avoid dropping trace files everywhere). This is best done by only saving when an optional save_as string argument evaluates to True.

@damaggu
Copy link
Member

damaggu commented Jul 20, 2017

Reviewed and edited suggested changes. Should work now, also atlas annotation fixed. For testing please replace filenames and in the labels csv line 177 replace ‘,’ by something else (

Accessory olfactory bulb: glomerular, external plexiform and mitral cell layer ), since it messes up the parsing.

result should be something like this
matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants