Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple PIs not supported; bad naming of PI-related props #24

Open
mirzov opened this issue Jun 2, 2021 · 3 comments · Fixed by #90
Open

Multiple PIs not supported; bad naming of PI-related props #24

mirzov opened this issue Jun 2, 2021 · 3 comments · Fixed by #90
Assignees

Comments

@mirzov
Copy link
Member

mirzov commented Jun 2, 2021

There are multiple ICOS stations with more than one PI. The object returned from e.g. station.get('CMN') does not reflect that. Additionally, it appears that the object representing the station has properties "firstName", "lastName" and "email", which clearly does not make sense. There should be property called "pis", with an array of objects representing people as the value.

Also, there is no reason for the "uri" property to be an array.

@claudiodonofrio claudiodonofrio linked a pull request Jul 14, 2022 that will close this issue
@claudiodonofrio
Copy link
Member

with update to pylib 0.1.15 all metadata is available as provided from ICOS data portal.

@mirzov
Copy link
Member Author

mirzov commented Sep 20, 2022

Just tested pylib_examples/ex2_station.ipynb notebook with pylib version 0.1.15. All the problems reported in this issue are still present.

@claudiodonofrio
Copy link
Member

this is solved by using the icoscp core - library, but should be discussed if it needs to be implemented into the icoscp pylib. issue is going to be reassigned to @ZogopZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants