External radios #214

TheMagnetar · 2017-02-15T20:07:16Z

When merged this pull request will:

Implement actions to use external radios.
Similar approach to vehicleracks (hence snippers as an author as well)

This is a first implementation of external radios. It works in the following way (I am looking at you oh mighty bug) and it requires ace_interaction in order to work.

For infantry units:

As a unit you have to share a radio (self interaction) in order for other units to have access to it. If the unit is captive or dead, all radios are automatically available.
An external unit can then "take the headset" (external interaction) and start using the radio (end user). The owner of the radio looses all possibility to transmit through the radio or access it through self interaction until it is given back. Since it still resides in inventory, it is still possible to open it (see limitations).
As an end user you can transmit, open, change the channel, volume, etc. as long as you are within 2m of the owner or you are on the same vehicle. Radio is labelled as "AN/PRC 152 ("name_of_the_owner") in self interaction.
The end user can give the radio back (external interaction) "return headset" or give it to another player "give headset"
No other player can take control of external radios while they are being used.
As a unit, you can always give the headset to any other unit.
All radios allow giving/taking the headset.

For vehicles:

No longer applies (functionality in vehicle racks).

Limitations:

At the moment all radios have this functionality. Maybe we could limit it to 148, 152 and 117F.
The owner of the radio cannot hear the transmission despite having the radio in the inventory. Ideally it would be good to be able to transmit/receive as well, but not at the same time: radios have headsets and/or external microphones/speakers that can be attached. The transmitting label should be displayed for the owner if the end user is transmitting as well and viceversa.
This implementation requires ACE3 to work (ace interaction). It is often the case that ACRE is run together with ACE but...
Radios directly on the ground cannot be accessed. Any ideas on how could this be implemented?

jonpas · 2017-02-15T21:12:07Z

At the moment all radios have this functionality. Maybe we could limit it to 148, 152 and 117F.

Yeah, we should limit them based on what connectors they have available I guess. 343 has no external headset after all (I think).

This implementation requires ACE3 to work (ace interaction). It is often the case that ACRE is run together with ACE but...

That's completely fine. One thing that should be done is simply checking isClass (configFile >> "CfgPatches" >> "ace_interact_menu", if not then the system simply won't work as you can't interact with it. It's how vehicle racks are (or will) be done as well. Actually by just not having interactions (which are config-based anyways) it should not error without ACE3 either, so that's all fine. (This is ACrE after all 😆 )

Charlie-Bayne · 2017-02-16T15:52:14Z

Ref. 343 - There are two variants. One has an I/O port for the user headset, whilst the commander variant has a cable that comes out of the bottom and goes into the manpack, like a passthrough so that they only have to wear one headset, and push the prestle on the relevant radio to transmit.

For our purposes though, I am sure removing the pass headset from the 343 would be sensible...

Sniperhid

As-side from the initial code comments:

I would like to see this not work for radios inside vehicle inventories - It saves a few complications not handling this case (initializing radios/accounting for vehicle racks later).
'Retrieve Radio' - I think should become 'Unshare Radio' particularly as it seems more precise (specially if a person isn't using the radio - maybe it should be retrieve if someone else is using the radio).
This NEEDS multiplayer testing as there's potential for several kinks throughout.

Sniperhid · 2017-02-18T22:54:26Z

addons/ace_interact/fnc_radioChildrenActions.sqf

+    };
+
+    private _idx = _pttAssign find _radio;
+    _txt = localize LSTRING(bindMultiPushToTalk);;


double ;;

Sniperhid · 2017-02-18T22:55:43Z

addons/ace_interact/fnc_radioChildrenActions.sqf

+    if (!(_radio in ACRE_ACTIVE_EXTERNAL_RADIOS)) then {
+        _action = ["acre_share_radio", localize LSTRING(shareRadio), "", {[(_this select 2) select 0, true] call EFUNC(sys_external,allowExternalUse)}, {!([(_this select 2) select 0] call EFUNC(sys_external,isRadioShared))}, {}, _params]  call ace_interact_menu_fnc_createAction;
+        _actions pushBack [_action, [], _target];
+        _action = ["acre_retrieve_radio", localize LSTRING(retrieveRadio), "", {[(_this select 2) select 0, false] call EFUNC(sys_external,allowExternalUse)}, {[(_this select 2) select 0] call EFUNC(sys_external,isRadioShared)}, {}, _params]  call ace_interact_menu_fnc_createAction;


I think changing the terminology from retrieve radio to unshare radio would be more accurcate

Sniperhid · 2017-02-18T23:00:41Z

addons/sys_external/fnc_getExternalUseStatus.sqf

+
+private _isShared = [_radioId] call FUNC(isRadioShared);
+
+private ["_isUsedExternally", "_owner", "_user"];


This should be mixed into the below lines
i.e. private _isUsedExternally = false;

Sniperhid · 2017-02-18T23:01:21Z

addons/sys_external/fnc_getExternalUseStatus.sqf

+_user = nil;
+
+if (_isShared) then {
+    private _isUsedExternally = [_radioId] call FUNC(isExternalRadioUsed);


using private here creates a new local variable in this private scope.

Sniperhid · 2017-02-18T23:01:25Z

addons/sys_external/fnc_getExternalUseStatus.sqf

+if (_isShared) then {
+    private _isUsedExternally = [_radioId] call FUNC(isExternalRadioUsed);
+    if (_isUsedExternally) then {
+        private _owner = [_radioId] call FUNC(getExternalRadioOwner);


using private here creates a new local variable in this private scope.

Sniperhid · 2017-02-18T23:01:30Z

addons/sys_external/fnc_getExternalUseStatus.sqf

+    private _isUsedExternally = [_radioId] call FUNC(isExternalRadioUsed);
+    if (_isUsedExternally) then {
+        private _owner = [_radioId] call FUNC(getExternalRadioOwner);
+        private _user = [_radioId] call FUNC(getExternalRadioUser);


using private here creates a new local variable in this private scope.

Sniperhid · 2017-02-18T23:02:38Z

addons/sys_external/fnc_startUsingExternalRadio.sqf

+// Add the radio to the player
+ACRE_ACTIVE_EXTERNAL_RADIOS pushBackUnique _radioId;
+
+player sideChat format ["Start using %1", _radioId];


I think systemChat should be used over player sideChat.

Sniperhid · 2017-02-18T23:02:43Z

addons/sys_external/fnc_stopUsingExternalRadio.sqf

+
+ACRE_ACTIVE_EXTERNAL_RADIOS = ACRE_ACTIVE_EXTERNAL_RADIOS - [_radioId];
+[1] call EFUNC(sys_list,cycleRadios); // Change active radio
+player sideChat format ["Stop using %1", _radioId];


I think systemChat should be used over player sideChat.

TheMagnetar · 2017-02-19T00:29:21Z

PR changes as requested by @Sniperhid

Radios inside vehicle inventories cannot be accessed.
Use of systemchat (debug only)
"Retrieve radio" -> "Unshare radio"

jonpas · 2017-02-23T00:14:16Z

At the moment all radios have this functionality. Maybe we could limit it to 148, 152 and 117F.

Add a config value for it. acre_canShare maybe.

jonpas · 2017-02-25T19:36:09Z

addons/sys_external/CfgVehicles.hpp

+                    statement = "true";
+                    insertChildren = QUOTE(_this call FUNC(listChildrenActions));
+                    priority = 0.1;
+                    icon = "\a3\Ui_f\data\GUI\Cfg\CommunicationMenu\call_ca.paa";


Can use ICON_RADIO_CALL macro now, since #239.

yes. I will update this accordingly. And also I will substitute systemchat by hints.
On a side note, the changes here are also ported to the implementation of external radios using hashes instead of storing information on radioData. We can decide later which implementation is better.

jonpas · 2017-02-25T22:54:52Z

addons/sys_external/fnc_startUsingExternalRadio.sqf

@@ -24,4 +24,4 @@ params ["_radioID", "_owner", "_endUser"];
 // Add the radio to the player
 ACRE_ACTIVE_EXTERNAL_RADIOS pushBackUnique _radioId;

-systemChat format ["Start using %1", _radioId];
+[format ["Start using %1", _radioId];] call EFUNC(sys_core,displayNotification);


No semi-colon in there.

jonpas · 2017-03-14T10:01:07Z

addons/sys_external/fnc_isExternalActionAvailable.sqf

 *
 * Arguments:
 * 0: Infantry unit <OBJECT>
 *
 * Return Value:
- * False
+ * <BOOL>


jonpas · 2017-03-14T10:01:26Z

addons/sys_external/fnc_childrenActions.sqf

-if (acre_player == [_radio] call FUNC(getExternalRadioOwner)) then {
-    _playerOwnsRadio = true;
-};
+private _playerOwnsRadio = (acre_player == [_radio] call FUNC(getExternalRadioOwner));


No outer parenthesis, it's just a simple boolean.

jonpas 3 days ago:
L24-L27 as: private _playerOwnsRadio = (acre_player == [_radio] call FUNC(getExternalRadioOwner));

That's why ;)

But you know better, I am just a scrub making you change things. 😆

jonpas

Note: doc page needs to be added to sidebar.

jonpas · 2017-03-17T08:58:28Z

docs/wiki/user/external-radios.md

@@ -0,0 +1,9 @@
+---
+title: External radios


External Radios

…into externalRadios

jonpas · 2017-03-26T16:49:42Z

addons/sys_data/fnc_getPlayerRadioList.sqf

@@ -22,6 +22,15 @@ if (alive acre_player) then {
    private _weapons = [acre_player] call EFUNC(sys_core,getGear);
    _radioList = _weapons select {_x call EFUNC(sys_radio,isUniqueRadio)};

+    // Remove those radios that are being actively used by other players.


No final dot.

jonpas · 2017-03-26T16:51:08Z

addons/sys_external/CfgVehicles.hpp

+    class CAManBase: Man {
+        class ACE_Actions {
+            class ACE_MainActions {
+                class ACRE_Interact {


Should be ACRE_Interact_External or something unique to the action - future proof.

jonpas · 2017-03-26T16:51:39Z

addons/sys_external/config.cpp

+    };
+};
+
+PRELOAD_ADDONS;


jonpas · 2017-03-26T16:51:46Z

addons/sys_external/fnc_allowExternalUse.sqf

@@ -0,0 +1,21 @@
+/*
+ * Author: ACRE2Team
+ * Mark a radio in order to enable/disable to be used by other units (external use)


Missing final dot.

jonpas · 2017-03-26T16:52:11Z

addons/sys_external/fnc_checkListChildrenActions.sqf

@@ -0,0 +1,26 @@
+/*
+ * Author: ACRE2Team
+ * Check if a given action is available for a specific radio and unit


Missing final dot.

jonpas · 2017-03-26T17:07:28Z

addons/sys_external/fnc_radioCheckChildrenActions.sqf

@@ -0,0 +1,24 @@
+/*
+ * Author: ACRE2Team
+ * Check if a given action is available for a specific radio external radio


Missing final dot.

jonpas · 2017-03-26T17:07:45Z

addons/sys_external/fnc_radioCheckChildrenActions.sqf

+
+if (vehicle acre_player != acre_player) exitWith {false};
+
+true


Entire thing as one direct return if.

jonpas · 2017-03-26T17:07:49Z

addons/sys_external/fnc_startUsingExternalRadio.sqf

@@ -0,0 +1,32 @@
+/*
+ * Author: ACRE2Team
+ * Start using an external radio


Missing final dot.

jonpas · 2017-03-26T17:07:57Z

addons/sys_external/fnc_stopUsingExternalRadio.sqf

+/*
+ * Author: ACRE2Team
+ * Stop using an external radio, either returning it to the owner or giving it to another player. If target
+ * is skipped, a default action to return to the owner is taken


Missing final dot.

jonpas · 2017-03-26T17:09:03Z

addons/sys_external/fnc_stopUsingExternalRadio.sqf

+ *
+ * Arguments:
+ * 0: Unique radio identity <STRING>
+ * 1: New end user/original owner <OBJECT>(Optional)


... <OBJECT> (default: objNull)
It's not actually optional per params though.

jonpas · 2017-03-26T21:44:09Z

addons/sys_data/fnc_getPlayerRadioList.sqf

-    private _externalRadiosInUse = _radioList select {_x call EFUNC(sys_external,isExternalRadioUsed)};
-    _radioList = _radioList - _externalRadiosInUse;
+    // Remove those radios that are being actively used by other players
+    _radioList = _radioList select {!(_x call EFUNC(sys_external,isExternalRadioUsed))};


This could be merged with L23 and form:

_radioList = _weapons select {_x call EFUNC(sys_radio,isUniqueRadio) && {!(_x call EFUNC(sys_external,isExternalRadioUsed))}};

for faster iteration (from 2n to n).

* Use code block for mods list in issue template * Hide radio self-interaction node if no radio in inventory * Introduce Variable to deactivated distance-based muting (#228) * Order radio ear left/right correctly * Cleanup and macros (#230) * Delete unused traces * QEFUNC Macro * Moved all opening braces on same line * Removed spaced after classes * Spaces and Indentation * More spaces * Fix direct speech page vehicle attenuation link * Add Custom Signal Processing wiki page to sidebar, Cleanup sidebar config * Use ACE3 notification if available instead of hint (#239) * Add displayNotification function * Fix log * Pass functions 'by reference' to BI evenEHs * acre_api_fnc_setCustomSignalFunc - reset fix (#227) * fixes the possibility to reset the function to default behavior * wrong term * lowercase if * Update documentation * Use of ICON_RADIO_CALL in ace_interact * Fix ctrSetEventHandler. Back to Quotes as in #241 (#243) Fix ctrlSetEventHandler - back to quotes as in #241 * Fixes the antenna direction calculation (#233) * Improve mod listing on issue template * Update easylogging++ to v9.94.1 (#246) * Update easylogging++ to v9.94.1, Bandaid prevent default log file from creation * Include easylogging++.cc in CMake, Change max file size to 1 MB * Hotfix muting variable (#248) * Fix duplicate ID handling (#251) * Fix acre failing initialise due to a race condition (#240) * Documentation -- Function Headers -- sys_prc343 (#110) * Changed function example calls * Headers 1 * Completed headers. Missing arguments * Improvements on Doc * Review changes * v2.4.0.943 - Build 37 * Use CBA Namespaces * 4nec2 Antenna Calculation (#244) - Switches Antenna Calculation from MMANA-GAL to 4NEC2 (Closes #201) - Converts all existing antenna data files to 4NEC2 ones - Adds additional antennas for e.g SEM52 (Closes #29) - Introduces a new script to convert 4NEC2 output files to ACRE's `*.aba` file * SEM70 (#199) Adds a new radio: SEM70, a manpack radio used by German Armed Forces. It comes with an UI, rendered in 3D like all other ACRE2 radios. Model and textures created by Raspu (https://github.com/Raspu86). Additionally it is the first radio featuring an automatic channel selection. Details will follow in the documentation. * Fixes * Fix duplicate mounted radios in racks * Infantry Phone (#224) * External intercom * Handle dead units using the intercom * Some requested changes * Lunch break fixes * Changes all references of external Intercom to Infantry Phone * DOC: Infantry telephone * Macroize interactions, Fix missing string * Add actions dynamically, Add support for custom position/selection * Improve things * Add vanilla Tanks and Tracker APCs custom positions, Disable debug * Fix in vehicle checks * Revert some changes from previous commit * Moved to sys_intercom * Call functionality implemented * Fix the spalling of own name * Fixes of example calls * Fix headers, Use clientInit postInit * Move intercom/infantry phone config to vehicle root class * Changed true/false to 1/0 in configs * Cleanup configs, Don't attach init EH if ACE3 disabled * Add vehicle intercom and infantry phone documentation * Use ACE3 notifications, Cleanup minor things * Added ringing description * Add additional line regarding ringing position in framework doc * Use displayNotification * Fix issue * Fix stupidity... * Fix displayNotification * Add infantry phone connected message * PhoneCall fixes * Remove of duplicate private * Prevent destroyed vehicle beeping and infantry phone interaction * Stop infantry phone from beeping if no crew members are aboard * Doc and lazy evaluation * HCs are kind of important * No need for code in code * Redefined infantry phone position for compatibility with other mods * Fix: sound in all clients * Fixed intercom * remoteExecCall to CBA_fnc_globalEvent * Privatising * inline functions though, yuck * Updated documentation * Fix SEM70 (#257) - Frequency default (stupid) - PBOPrefix was ooold - Disable Debugging * Use CBA Namespaces * v2.4.0.944 - Build 38 * Update Documentation Theme (#253) * Add url to branching image, Put --incremental guideline as optional * Update Jekyll Documentation Theme to 06dc9e0e257e014d1ccf9de158e76a61d74f84e6 * Remove redundant tooltips files, Fix search * Use url from file location by default for images * Renamed settings variables (#259) * Teamspeak channel switching functionality (#225) * Initial commit for channel move functionality * Changes as per previous review * Request changes and improvements * Fixed incorrect use of EGVAR * Requested changes. Normalised name to TS3 and normalised formatting. * Improved name search utilising Levenshtein distance * Whitespace * Requested changes * Whitespaceroni * Requested changes * Removed comment from pipe timeout * Use display XEH instead of PFH * Add missing checks in display XEH * Removes extra include causing make error (#261) * Removes extra include causing make error * There was another one as well... * Use custom namespace for Fast Hashes (#267) * Use custom location with invalid drawStyle for fast hashes to improve performance * Fully move hashes to sys_core * Move the rest of fast hashes to sys_core, Fix crash in PREP * Prefix global fast hash variables * Remove redundant code * Fix missing renames * Move all fast hash stuff to main * Create menu hashes before using them * Return Menu hashes to working location * Cleanup 117f and 152 menus compilation (don't run in preStart) * Use custom namespace for Fast Hashes (#267) * Use custom location with invalid drawStyle for fast hashes to improve performance * Fully move hashes to sys_core * Move the rest of fast hashes to sys_core, Fix crash in PREP * Prefix global fast hash variables * Remove redundant code * Fix missing renames * Move all fast hash stuff to main * Create menu hashes before using them * Return Menu hashes to working location * Cleanup 117f and 152 menus compilation (don't run in preStart) * v2.4.0.945 - Build 39 * v2.4.0.946 - Build 6 * Actually increment patch version * v2.4.1.947 - Build 7 * Polish translation. (#268) Polish translation * Box with radios (#265) * Box with radios * Requested changes * Added forgotten displayName * Added box to units[] in CfgPatches * Rename tag, lower amount of radios, more small radios than big radios * Clean-up and document to sys_io (#249) * Some improvements to sys_io * Improve mentions of the extension. * Improve comments * Added SEM70 to main readme (#270) * External radios (#214) * First implementation of external radios * Fixes, vehicles added and tweaked availability of ace actions * Fixes * Fixes and remove debug * Fixes and improvements * Fixed vehicles * Updated german translations * Improved ace interaction actions * Fixed Doc * Prevent the use of an external radio if it is already in use * PR requested changes * Additional fixes * Moved ace_interaction related functions to sys_external * Update notifications and use of icon macro * Removed extra semicolons * Hide entry if no radios are shared externally * Allow players to give the radio headsets to other units * Radio owner awareness * Requested changes * Requested changes and documentation * Adding new page to sidebar * Fix doc entry in side-bar * Fixes * Removed tabs at the end of line * Set external radio as active and improve messages * Fixed display messages * Prevent action from showing if distance is too large * Requested changes * Tabs tabs tabs. those hateful tabs * Forgetful magnetar * Forgetful magnetar. Part 2. * Further optimisations * Intercom overhaul and passenger intercom (#255) * External intercom * Handle dead units using the intercom * Some requested changes * Lunch break fixes * Changes all references of external Intercom to Infantry Phone * DOC: Infantry telephone * Macroize interactions, Fix missing string * Add actions dynamically, Add support for custom position/selection * Improve things * Add vanilla Tanks and Tracker APCs custom positions, Disable debug * Fix in vehicle checks * Revert some changes from previous commit * Moved to sys_intercom * Call functionality implemented * Fix the spalling of own name * Fixes of example calls * Fix headers, Use clientInit postInit * Move intercom/infantry phone config to vehicle root class * Changed true/false to 1/0 in configs * Cleanup configs, Don't attach init EH if ACE3 disabled * Add vehicle intercom and infantry phone documentation * Use ACE3 notifications, Cleanup minor things * Added ringing description * Add additional line regarding ringing position in framework doc * Use displayNotification * Fix issue * Fix stupidity... * Fix displayNotification * Add infantry phone connected message * PhoneCall fixes * Remove of duplicate private * Prevent destroyed vehicle beeping and infantry phone interaction * Stop infantry phone from beeping if no crew members are aboard * Doc and lazy evaluation * HCs are kind of important * No need for code in code * Redefined infantry phone position for compatibility with other mods * First implementation * Fix: sound in all clients * Fixed intercom * Fixes for passenger intercom * cba_fnc_globalEvent instead of remoteExecCall * Requested changes * Requested changes II * Intercom overhaul and passenger intercom * CBA settings and network optimisations * Fixed: prevent from connecting to passenger intercom when the phone is ringing * Fixes and corner cases * BLUFOR vehicles * Fixed attenuation checks * Helicopters, SDVs and VTOLS * Added hook for custom actions on Inf. phone change status * Documentation formatting issues * Update Documentation * Don't use negation * Fixes + doc * Remove debug comment * Requested changes * Removed fnc_intercomActions.sqf since it was no longer needed * Optimisations and noApiFunctions for debugging purposes * Improve config inheritance, Check event type * Passenger to Pax, Add note * Shorten Inf Phone strings * Formatting of ace actions and removal of switch intercom message * v2.4.1.948 - Build 40 * Fix Vehicle Intercom Framework documentation page * Formatting * TS3 channel switching documentation (#272) * Added TS3 channel switching documentation * Few grammar changes * Changes * Hash be gone * Empty lines * Russian translation (#278) * no message * PAX translations. * Power fixes and request changes

TheMagnetar added 7 commits February 14, 2017 01:19

First implementation of external radios

290f7b4

Fixes, vehicles added and tweaked availability of ace actions

5635fa3

Merge branch 'master' into externalRadios

afa7771

Fixes

2726b17

Fixes and remove debug

1eade61

Fixes and improvements

e5bad47

Fixed vehicles

5c871ad

jonpas added the feature request label Feb 15, 2017

jonpas added this to the 2.5.0 milestone Feb 15, 2017

Sniperhid self-requested a review February 15, 2017 21:10

Updated german translations

5880acc

TheMagnetar and others added 4 commits February 16, 2017 23:24

Improved ace interaction actions

ea2bbfb

Merge branch 'master' into externalRadios

9e4a49a

Fixed Doc

1e1dd1d

Prevent the use of an external radio if it is already in use

da9b61d

Sniperhid previously requested changes Feb 18, 2017

View reviewed changes

PR requested changes

733e299

Additional fixes

a325fba

TheMagnetar added 3 commits February 24, 2017 18:29

Merge branch 'master' into externalRadios

0db2318

Merge branch 'master' into externalRadios

20c658b

Moved ace_interaction related functions to sys_external

89bbf64

jonpas reviewed Feb 25, 2017

View reviewed changes

Update notifications and use of icon macro

f63c5e9

jonpas reviewed Feb 25, 2017

View reviewed changes

TheMagnetar added 2 commits February 25, 2017 23:58

Removed extra semicolons

7117edf

Merge remote-tracking branch 'upstream/master' into externalRadios

3c91603

TheMagnetar added 2 commits March 12, 2017 00:32

Merge branch 'master' into externalRadios

450060e

Requested changes

3b3f42f

jonpas requested changes Mar 14, 2017

View reviewed changes

Requested changes and documentation

f58fe82

jonpas requested changes Mar 17, 2017

View reviewed changes

docs/wiki/user/external-radios.md Outdated

@@ -0,0 +1,9 @@

---

title: External radios

Copy link

Member

jonpas Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

External Radios

TheMagnetar added 3 commits March 17, 2017 10:23

Adding new page to sidebar

681a732

Merge branch 'externalRadios' of https://github.com/TheMagnetar/acre2 …

4f56699

…into externalRadios

Fix doc entry in side-bar

ca2ee40

TheMagnetar force-pushed the externalRadios branch from 03a354d to ca2ee40 Compare March 17, 2017 19:37

TheMagnetar added 3 commits March 17, 2017 21:51

Fixes

8723ce9

Removed tabs at the end of line

b4ca85d

Set external radio as active and improve messages

ec529f2

TheMagnetar force-pushed the externalRadios branch from 1e3b99e to ec529f2 Compare March 20, 2017 13:15

TheMagnetar added 2 commits March 20, 2017 17:26

Fixed display messages

049f929

Prevent action from showing if distance is too large

aa98d82

jonpas requested changes Mar 26, 2017

View reviewed changes

TheMagnetar added 2 commits March 26, 2017 22:51

Requested changes

cdce41f

Tabs tabs tabs. those hateful tabs

eb5a93e

jonpas approved these changes Mar 26, 2017

View reviewed changes

Forgetful magnetar

aa3e32f

jonpas requested changes Mar 26, 2017

View reviewed changes

TheMagnetar added 2 commits March 26, 2017 23:45

Forgetful magnetar. Part 2.

6d6cf5b

Further optimisations

3377e28

jonpas approved these changes Mar 27, 2017

View reviewed changes

jonpas merged commit 44958c8 into IDI-Systems:master Mar 27, 2017

jonpas modified the milestones: 2.5.0, 2.6.0 Sep 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

External radios #214

External radios #214

TheMagnetar commented Feb 15, 2017 •

edited

Loading

jonpas commented Feb 15, 2017 •

edited

Loading

Charlie-Bayne commented Feb 16, 2017

Sniperhid left a comment

Sniperhid Feb 18, 2017

Sniperhid Feb 18, 2017

Sniperhid Feb 18, 2017

Sniperhid Feb 18, 2017

Sniperhid Feb 18, 2017

Sniperhid Feb 18, 2017

Sniperhid Feb 18, 2017

Sniperhid Feb 18, 2017

TheMagnetar commented Feb 19, 2017

jonpas commented Feb 23, 2017

jonpas Feb 25, 2017 •

edited

Loading

TheMagnetar Feb 25, 2017 •

edited

Loading

jonpas Feb 25, 2017

jonpas Mar 14, 2017

jonpas Mar 14, 2017

TheMagnetar Mar 14, 2017

jonpas Mar 14, 2017

jonpas left a comment

jonpas Mar 17, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017

jonpas Mar 26, 2017


		private _isShared = [_radioId] call FUNC(isRadioShared);

		private ["_isUsedExternally", "_owner", "_user"];


		if (vehicle acre_player != acre_player) exitWith {false};

		true

External radios #214

External radios #214

Conversation

TheMagnetar commented Feb 15, 2017 • edited Loading

jonpas commented Feb 15, 2017 • edited Loading

Charlie-Bayne commented Feb 16, 2017

Sniperhid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheMagnetar commented Feb 19, 2017

jonpas commented Feb 23, 2017

jonpas Feb 25, 2017 • edited Loading

Choose a reason for hiding this comment

TheMagnetar Feb 25, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonpas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheMagnetar commented Feb 15, 2017 •

edited

Loading

jonpas commented Feb 15, 2017 •

edited

Loading

jonpas Feb 25, 2017 •

edited

Loading

TheMagnetar Feb 25, 2017 •

edited

Loading