Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Racks interaction usability #526

Merged
merged 6 commits into from
May 10, 2018
Merged

Improve Racks interaction usability #526

merged 6 commits into from
May 10, 2018

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented May 10, 2018 •
edited
Loading

When merged this pull request will:

  • Shorten Dashboard Lower and Upper stringtables
    • Make them fit into 1 ACE3 Interaction Menu line
    • Conform with single Dash action
  • Correct display name of AN/VRC-64
  • Improve rack interaction usability - close Racks interaction usability #522
    • Add channel label to radio name
    • Move Unmountable and Unmount texts as radio sub-actions ("Unmountable" is dummy action)
    • Change radio action to open radio instead of unmount (conform with self-interaction, avoid confusion and mistakes)
    • Cleanup rack children actions function

20180510204355_1
20180510204342_1

@jonpas
Shorten Dashboard Lower and Upper stringtables
08e221b 
Make them fit into 1 ACE3 Interaction Menu line
Conform with single Dash action
@jonpas
Correct display name of AN/VRC-64
9bfbc50
@jonpas
Improve rack interaction usability
d7ef4d1 
Add channel label to radio name
Move Unmountable and Unmount texts as radio sub-actions (unmountable dummy action)
Change radio action to open radio instead of unmount (conform with self-interaction, avoid confusion and mistakes)
Cleanup rack children actions function
@jonpas jonpas added this to the 2.6.0 milestone May 10, 2018
@jonpas jonpas requested a review from TheMagnetar May 10, 2018 18:50
TheMagnetar
TheMagnetar requested changes May 10, 2018
View reviewed changes
addons/sys_rack/fnc_rackChildrenActions.sqf
QGVAR(mountedRadio),
_displayName,
_icon,
{[_this#2#1] call EFUNC(sys_radio,openRadio)},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sitll think that this looks awful and reduces code readability

addons/ace_interact/fnc_radioListChildrenActions.sqf Outdated
@@ -44,7 +44,7 @@ private _radioList = [] call EFUNC(api,getCurrentRadioList);
private _currentChannel = [_x] call EFUNC(api,getRadioChannel);
_displayName = format [localize LSTRING(channelShort), _displayName, _currentChannel];
private _picture = getText (_item >> "picture");
private _isActive = _x isEqualTo _currentRadio;
private _isActive = _x isEqualTo _currentRadio; // Unused
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not delete the variable then rather than having it defined?

Copy link
Member Author

@jonpas jonpas May 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future use, already passed down the rabbit hole of function calls.
It's actually used...

addons/sys_rack/stringtable.xml
@@ -98,7 +98,7 @@
<Italian>Cruscotto</Italian>
</Key>
<Key ID="STR_ACRE_sys_rack_dashLower">
<English>Dashboard Lower</English>
<English>Dash Lower</English>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dash is not the same as dashboard if I am not mistaken.

Copy link
Member Author

@jonpas jonpas May 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided it will be changed in the future if that's true. AFAIK "Dash" can just be used as short form of "Dashboard", and it fits interaction menu in a much nicer way.

Copy link
Contributor

@Drofseh Drofseh May 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dash is short for dashboard.

"Don't put your coffee on the dash."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect then. My bad.

@jonpas jonpas merged commit a774fd1 into master May 10, 2018
@jonpas jonpas deleted the racks-usability branch May 10, 2018 20:11
@Drofseh
Copy link
Contributor

Drofseh commented May 10, 2018

What does the Channel Label show with the AN/PRC-77?

@jonpas
Copy link
Member Author

jonpas commented May 10, 2018

"Chn: 1" always. It's using the same function as self-interaction when the radio is on your character.

@jonpas jonpas added the cleanup label May 10, 2018
@Drofseh Drofseh mentioned this pull request May 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMagnetar TheMagnetar TheMagnetar approved these changes

@Drofseh Drofseh Drofseh left review comments

Assignees
No one assigned
Labels
cleanup enhancement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

Racks interaction usability
3 participants
@jonpas @Drofseh @TheMagnetar