Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this great implementation!
When playing with it I realized that my computer RAM was getting quite full and that every call to encodeBin or decodeBin will have to be casted by PyBind11, which introduced lots of overhead in memory and computation.
The following proposed modifications focus on:
I've added a file called Changes_and_performance_comparison.md in which this is depicted and some statistics are presented, showing a huge improve in computation and memory use.
Also some demos to easily replicate.
Hope you like this modifications!!