-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Get /services/:service
implementation
#49
Comments
You will have to update the api.yaml because there is no id in the response of this route. But it could be interesting to have the same object for this route and the /services route. What do you think ? |
@lgrd There is no Does it look good for you ? |
Oh ! I got the point... Now, you have this in the yaml :
This is because, when you POST or PATCH a service, you will not give the id inside the body. It is only inside the URL parameter. That's why I add it only in the response of /services. So, to be in line with the other /service/{serviceId}, let us keep the api.yaml like it is. So, in your code section, you can only read the content of service.json and return it. You don't have to add the id. Is that ok for you ? |
Sorry I did not see that |
thanks ! I will test your code tomorrow but it looks good ! ;) |
Create GET
/services/:service
like it is specified inside https://github.com/IGNF/road2/blob/develop/documentation/apis/administration/1.0.0/api.yaml.Code
getServicesConfigurations()
to use the newgetServiceConfiguration()
to get configuration for each serviceThe text was updated successfully, but these errors were encountered: