Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identifier 2..* cardinality on SubmissionSet unclear #92

Closed
simoneOnFhir opened this issue Sep 23, 2021 · 9 comments
Closed

identifier 2..* cardinality on SubmissionSet unclear #92

simoneOnFhir opened this issue Sep 23, 2021 · 9 comments
Assignees

Comments

@simoneOnFhir
Copy link

It is unclear which two identifiers are required here, since only one of the slices in mandatory.
See discussion on Zulip: https://chat.fhir.org/#narrow/stream/179223-ihe

@JohnMoehrke
Copy link
Contributor

@JohnMoehrke
Copy link
Contributor

It is seeming to me that the entryUUID is to eb-Registry as the FHIR Reference elements are to FHIR. Thus at the MHD clients there should be no mention of entryUUID, except to allow it to be carried. There is nothing a MHD client can do with the entryUUID, and any Document Source actions in MHD need to use the Reference elements, and not entryUUID.

MHD Document Source would use Reference elements for everything that an XDS Document Source would entryUUID values for. For example replacing a previous document, would be done by an MHD Document Source through DocumentReference.relatesTo.target (Reference).

Further there is no way for a MHD Document Source to properly process entryUUID. Indeed even on a create the MHD Document Source is expected to set the DocumentReference.id according to FHIR rules, but has no rules that it would know how to properly set the entryUUID.

Where MHD is an api to XDS, the MHD Document Responder should translate entryUUID into the FHIR resources. the MHD Document Consumer should expect to sometimes see entryUUID, there is a small use-case where a MHD Document Consumer may need to lookup an XDS object by the entryUUID (unusual, but possible).

Thus the profiles should

  • continue to define proper placement for entryUUID
  • stop requiring entryUUID

This would mean that in an MHDS environment, there would be no entryUUID at all, as FHIR Resource elements would fulfill all of these requirements. (Not clear that MHDS should forbid entryUUID values. This could be done, but not clear it adds any benefit or prevents any problem).

@JohnMoehrke JohnMoehrke added the Discussion Committee Discussion needed label Oct 21, 2021
@oliveregger
Copy link
Contributor

this applies also to the DocumentEntry.identifier requirement 1...* for the entryUUID.

@oliveregger
Copy link
Contributor

Should adapt slicing/cardinalities that for MHD entryUUID can be provided but for MHDS entryUUID is not required.

@oliveregger
Copy link
Contributor

could the entryUUID be made optional for MHD and the Document Responder would need to provide the entryUUID .

@JohnMoehrke
Copy link
Contributor

JohnMoehrke commented Apr 28, 2022

For DocumentReference

The MHD Document Source is already forbidden from providing an entryUUID (section 2:3.65.4.1.2), while the .identifier element is required

-> Should be "May", or do we want it to be shall not?

So, changing the .identifier to 0..*

@JohnMoehrke
Copy link
Contributor

For SubmissionSet

changed identifier from 2..* to 0..*, and added a short explaining what might be placed here.

inserted in expected actions (ITI-65) a requirement to create entryUUID values as needed.

@JohnMoehrke
Copy link
Contributor

For Folder

dropped to 0..*, and added short explaining

@JohnMoehrke
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants