-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename startCanvas to start, allow ref to part of a Canvas #1320
Comments
Agree with the user experience, but is
A viewer that can be given a highlighting anno to initialise with can use exactly the same mechanism when the info is provided in the manifest. I don't mind |
|
While we're renaming things ... |
👍 to |
I realize it was my suggestion, but I can't think of a reason why |
👍 to |
👍 to |
So new proposal, that I think we're all +1 on... Proposal: Rename |
Community agreement on 12/20 |
Can Allowing |
I think it should point to either a range or a canvas/part-of-canvas, but not either as then there'd be two ways to accomplish the same thing, forcing a decision on the production side and two implementations on the consumption side. I'd prefer just the Canvas, as there may not be an appropriate range that you'd want to expose. So I'm 👎 on start referencing a Range, unless there's some functionality that a Range would offer us over the Canvas (and then we could have it as /just/ the Range?) |
Now that Canvases can have a duration, the start of the startCanvas is not necessarily the beginning of the duration. It could be that the interesting part of the content begins on the first canvas, but not at the beginning of its duration. This would let the player initialize to a temporal offset within the Canvas, rather than playing the 10 seconds of silence or 3 minutes of audience noise at the beginning.
For x,y canvases, this would allow scrolling to a region of the Canvas, such as the most interesting part of the 150k px Princeton scroll.
Proposal:
startCanvas
can also refer to a Canvas with a fragment, in the same way that Ranges can.The text was updated successfully, but these errors were encountered: