-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0006 internationalization and multi-language values #215
Conversation
Comments from the Cookbook editors: Implementation notes
"It should be noted that BCP 47 allows hyphen breaks for locale and scripts (e.g. en-US) and if you are processing these manifests with Javascript it will break the . notation features for navigating JSON object so you should use brackets for accessing language properties." ExampleCould you change: “The image was sourced via Wikimedia Commons and is public domain.” to “The image in this example was sourced via Wikimedia Commons and is public domain.” Related recipesCould you remove the existing ones as they don't seem awfully relevant and add a link to the rights and metadata recipes? Other than the above the editors were happy for this to go to TRC without another review. |
Thanks, @glenrobson. I made the requested changes, but had to rework the Implementation notes section a bit since just moving the two paragraphs to the top affected the flow. Can you review the edits to make sure they look OK and achieve the desired result? |
It looks great Dawn. Thanks |
This has been approved by the TRC but they have requested the following changes:
|
@glenrobson - I removed the |
Sorry Dawn would it be possible to include the subject example in addition to the author one? I think its useful to show both and I believe the intention of the comment from TRC was in addition rather than replacing. |
@glenrobson I can add the author back in, but I can't really make that one both French and English which is why I switched it to Subject. It will still use "none" for the value language map -- will that be OK? There is another instance of "none", so I thought that might be enough. |
Thanks Dawn thats perfect. I think its important to show what I think will be a common use case that you have translated labels but not content. |
Issue: #6
Preview: https://preview.iiif.io/cookbook/0006-multilingual/recipe/0006-text-language/