Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0006 internationalization and multi-language values #215

Merged
merged 36 commits into from
Jan 13, 2021

Conversation

kirschbombe
Copy link
Contributor

@kirschbombe kirschbombe commented Nov 4, 2020

@kirschbombe kirschbombe self-assigned this Nov 4, 2020
@kirschbombe kirschbombe added this to To Do in Recipe Progress via automation Nov 4, 2020
@kirschbombe kirschbombe changed the title 0006 internationalization and multi-lingual labels 0006 internationalization and multi-language values Nov 11, 2020
@glenrobson
Copy link
Member

Comments from the Cookbook editors:

Implementation notes

  • Could you move the last two paragraphs to the front as they seem very important messages for the reader.
  • Could you re-write the dot notation message to:

"It should be noted that BCP 47 allows hyphen breaks for locale and scripts (e.g. en-US) and if you are processing these manifests with Javascript it will break the . notation features for navigating JSON object so you should use brackets for accessing language properties."

Example

Could you change: “The image was sourced via Wikimedia Commons and is public domain.” to “The image in this example was sourced via Wikimedia Commons and is public domain.”

Related recipes

Could you remove the existing ones as they don't seem awfully relevant and add a link to the rights and metadata recipes?

Other than the above the editors were happy for this to go to TRC without another review.

@kirschbombe
Copy link
Contributor Author

Thanks, @glenrobson. I made the requested changes, but had to rework the Implementation notes section a bit since just moving the two paragraphs to the top affected the flow. Can you review the edits to make sure they look OK and achieve the desired result?

@glenrobson glenrobson moved this from Cookbook group review to TRC Review in Recipe Progress Dec 3, 2020
@glenrobson glenrobson linked an issue Dec 3, 2020 that may be closed by this pull request
@glenrobson
Copy link
Member

It looks great Dawn. Thanks

@glenrobson
Copy link
Member

This has been approved by the TRC but they have requested the following changes:

  • Remove the none case from the label in example lines 12-14
  • It would be useful to have an example of a metadata element with both labels and values in multiple languages (French and English as per the current examples)

@glenrobson glenrobson moved this from TRC Review to TRC Approved - waiting for merge in Recipe Progress Jan 8, 2021
@glenrobson glenrobson added the meta: approved-by-trc Recipe has been approved by the TRC label Jan 8, 2021
@kirschbombe
Copy link
Contributor Author

@glenrobson - I removed the none case from the manifest label and I updated the summary property with both English and French. I also changed the field in the metadata property to "Subject" and included subject values in both English and French. This should take care of the fixes, but let me know if it still needs work.

@glenrobson
Copy link
Member

Sorry Dawn would it be possible to include the subject example in addition to the author one? I think its useful to show both and I believe the intention of the comment from TRC was in addition rather than replacing.

@kirschbombe
Copy link
Contributor Author

kirschbombe commented Jan 9, 2021

@glenrobson I can add the author back in, but I can't really make that one both French and English which is why I switched it to Subject. It will still use "none" for the value language map -- will that be OK? There is another instance of "none", so I thought that might be enough.

@glenrobson
Copy link
Member

Thanks Dawn thats perfect. I think its important to show what I think will be a common use case that you have translated labels but not content.

@glenrobson glenrobson merged commit 311ab99 into master Jan 13, 2021
Recipe Progress automation moved this from TRC Approved - waiting for merge to Done Jan 13, 2021
@glenrobson glenrobson deleted the 0006-multilingual branch January 13, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: approved-by-trc Recipe has been approved by the TRC
Projects
Development

Successfully merging this pull request may close these issues.

Multiple languages / Internationalization
2 participants