Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #006: Internationalization and Multi-language Values #53

Open
glenrobson opened this issue Dec 3, 2020 · 4 comments
Open

Recipe #006: Internationalization and Multi-language Values #53

glenrobson opened this issue Dec 3, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This recipe introduces multi lingual labels into Manifests. It links to the relevant language codes and goes through some of restrictions and gotchas when working with multiple languages. The example includes multi language in the label, metadata, summary and requiredStatement fields.

The original issue covered multilingual as well as multi value but through discussion it was decided to split out the multivalue into a separate issue to keep this one more focused.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down).

Changes to the recipe will only be made after the TRC voting process has concluded.

@glenrobson glenrobson added this to the December 2020 milestone Dec 3, 2020
@zimeon
Copy link
Member

zimeon commented Dec 9, 2020

+1 but, per TRC discussion, I would remove the none case from the label in example lines 12-14 (notwithstanding that the same confusion of extra information in the none case exists in the specification 4.4. Language of Property Values example)

@kirschbombe
Copy link

Per TRC discussion, add additional descriptive metadata field that includes a value in both FR and EN

@nfreire
Copy link

nfreire commented Dec 9, 2020

+1 , but it would be useful to have an example of a metadata element with both labels and values in multiple languages (French and English as per the current examples)

@glenrobson
Copy link
Member Author

Issue 53 (Recipe #6: Internationalization and Multi-language Values)

+1: 20 [azaroth42 cubap emulatingkat gigamorph glenrobson irv jonhartzler jtweed julsraemy ksclarke markpatton mcwhitaker mixterj mposton-folger nfreire regisrob rentonsa tpendragon triplingual zimeon]
0: 0 []
-1: 0 []
Not TRC: 0 []
Ineligible: 4 [dismorfo jpstroop jwd mejackreed]

Result: 20 / 20 = 1.00

Super majority is in favor, issue is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants