Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround to fix #929 #945

Conversation

radpet
Copy link
Contributor

@radpet radpet commented Jun 2, 2016

Add workaround to fix #929 by manually setting the display to block inside the complete animation callback. I tried to find all .show() functions that might have been affected and add the fix.

I would like to ask what code beautifier to use in order to have consistency with the other contributors.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 40.786% when pulling dde7607 on SirmaITT:bugfix/ff_iframe_issue#929 into 76a35e7 on IIIF:release2.1.

@rsinghal
Copy link
Collaborator

rsinghal commented Jun 2, 2016

@radpet Can you resubmit your PR without all of the whitespace changes? I can't see what changes you made.

@radpet radpet force-pushed the bugfix/ff_iframe_issue#929 branch from dde7607 to 45c4bf0 Compare June 6, 2016 12:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 40.706% when pulling 45c4bf0 on SirmaITT:bugfix/ff_iframe_issue#929 into 76a35e7 on IIIF:release2.1.

@radpet radpet force-pushed the bugfix/ff_iframe_issue#929 branch 3 times, most recently from 075d034 to 3d1b14e Compare June 6, 2016 12:20
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 40.692% when pulling 3d1b14e on SirmaITT:bugfix/ff_iframe_issue#929 into 76a35e7 on IIIF:release2.1.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 40.736% when pulling 125317c on SirmaITT:bugfix/ff_iframe_issue#929 into 76a35e7 on IIIF:release2.1.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 40.692% when pulling 3d1b14e on SirmaITT:bugfix/ff_iframe_issue#929 into 76a35e7 on IIIF:release2.1.

@radpet radpet force-pushed the bugfix/ff_iframe_issue#929 branch from 3d1b14e to 5d4c8cb Compare June 6, 2016 13:15
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 40.706% when pulling 5d4c8cb on SirmaITT:bugfix/ff_iframe_issue#929 into 76a35e7 on IIIF:release2.1.

…lay to block inside the complete animation callback
@radpet radpet force-pushed the bugfix/ff_iframe_issue#929 branch from 5d4c8cb to 18b2824 Compare June 6, 2016 13:34
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 41.207% when pulling 18b2824 on SirmaITT:bugfix/ff_iframe_issue#929 into 76a35e7 on IIIF:release2.1.

@rsinghal rsinghal merged commit e8a5739 into ProjectMirador:release2.1 Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants