-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround to fix #929 #945
Merged
rsinghal
merged 1 commit into
ProjectMirador:release2.1
from
sirmaenterprise:bugfix/ff_iframe_issue#929
Jun 9, 2016
Merged
Add workaround to fix #929 #945
rsinghal
merged 1 commit into
ProjectMirador:release2.1
from
sirmaenterprise:bugfix/ff_iframe_issue#929
Jun 9, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@radpet Can you resubmit your PR without all of the whitespace changes? I can't see what changes you made. |
radpet
force-pushed
the
bugfix/ff_iframe_issue#929
branch
from
June 6, 2016 12:03
dde7607
to
45c4bf0
Compare
radpet
force-pushed
the
bugfix/ff_iframe_issue#929
branch
3 times, most recently
from
June 6, 2016 12:20
075d034
to
3d1b14e
Compare
radpet
force-pushed
the
bugfix/ff_iframe_issue#929
branch
from
June 6, 2016 13:15
3d1b14e
to
5d4c8cb
Compare
…lay to block inside the complete animation callback
radpet
force-pushed
the
bugfix/ff_iframe_issue#929
branch
from
June 6, 2016 13:34
5d4c8cb
to
18b2824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workaround to fix #929 by manually setting the display to block inside the complete animation callback. I tried to find all .show() functions that might have been affected and add the fix.
I would like to ask what code beautifier to use in order to have consistency with the other contributors.