Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF: Mirador in second tab is empty after loading #929

Closed
radpet opened this issue May 13, 2016 · 3 comments
Closed

FF: Mirador in second tab is empty after loading #929

radpet opened this issue May 13, 2016 · 3 comments
Labels
Mirador 2 Mirador 2

Comments

@radpet
Copy link
Contributor

radpet commented May 13, 2016

mirado2.zip

Loading mirador in iframe inside display:none parent causes the image to be loaded but not shown.

Steps to reproduce
Open test.html
Wait until the image is loaded.
Go to tab 2
See that there is no image shown, although it loads the image and if you go to the element which displays the image and set its style to display:block it will show it.

It happens under Firefox only. Maybe it is because mirador does not handle the event that sets its canvas to be visible.

@beaudet
Copy link

beaudet commented May 13, 2016

This is causing an issue with embedding Mirador in ConservationSpace.

@rsinghal
Copy link
Collaborator

I can recreate this, but don't know why it's happening. I look forward hearing about any more information you find.

@radpet
Copy link
Contributor Author

radpet commented May 25, 2016

It seems that firefox does not like this line
https://github.com/IIIF/mirador/blob/release2.1/js/src/widgets/imageView.js#L343
Adding display:block !important via class or changing show() to css('display','block') also works.
I'll be working on this and send pr as soon as I find better way to fix it. By the way it might be jquery show() issue on firefox but I am not sure yet. Any other ideas?

radpet added a commit to sirmaenterprise/mirador that referenced this issue Jun 2, 2016
…lay to block inside the complete animation callback
radpet added a commit to sirmaenterprise/mirador that referenced this issue Jun 2, 2016
…lay to block inside the complete animation callback
radpet added a commit to sirmaenterprise/mirador that referenced this issue Jun 6, 2016
…lay to block inside the complete animation callback
radpet added a commit to sirmaenterprise/mirador that referenced this issue Jun 6, 2016
…lay to block inside the complete animation callback
radpet added a commit to sirmaenterprise/mirador that referenced this issue Jun 6, 2016
…lay to block inside the complete animation callback
radpet added a commit to sirmaenterprise/mirador that referenced this issue Jun 6, 2016
…lay to block inside the complete animation callback
radpet added a commit to sirmaenterprise/mirador that referenced this issue Jun 6, 2016
…lay to block inside the complete animation callback
radpet added a commit to sirmaenterprise/mirador that referenced this issue Jun 6, 2016
…lay to block inside the complete animation callback
rsinghal added a commit that referenced this issue Jun 9, 2016
@cbeer cbeer added the Mirador 2 Mirador 2 label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mirador 2 Mirador 2
Projects
None yet
Development

No branches or pull requests

4 participants