Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #64: Table of Contents for Multiple A/V Files on a Single Canvas #58

Open
glenrobson opened this issue Jan 13, 2021 · 4 comments
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This pull request is in response to a couple of issues raised about a recipe that has already gone through the TRC approval process and is available on the live site. The changes requested were significant enough that it was though they should be approved by the TRC. The three changes are detailed in the issues linked above but comprise:

  1. Originally the manifest had two AnnotationPages in a single canvas each with a link to a video which makes up the complete presentation. The change requested was instead to have a single AnnotaitonPage with two annotations rather than two AnnotationPages.
  2. The second change was a bug in that the first linked video was to a presentation of the two acts in a single file where the intention was to only link to the video with the first act.
  3. The first video annotation originally only had a start time and not an end time. Following the MediaFragments spec this would imply the recording should play from the start to the end of the canvas and be stretched rather than just play the video between time t=0 and t=3971.24.

The unedited recipe is available for comparison at:

https://iiif.io/api/cookbook/recipe/0064-opera-one-canvas/

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down).

Changes to the recipe will only be made after the TRC voting process has concluded.

@glenrobson glenrobson added this to the January 2021 milestone Jan 13, 2021
@regisrob
Copy link
Member

regisrob commented Feb 2, 2021

The recipe is fine but unfortunately the main feature is not supported by Mirador and UV (Mirador does not handle the two annotations on the same Canvas nor the ToC for audio files; and UV seems to have a bug in the ToC).

@glenrobson
Copy link
Member Author

glenrobson commented Feb 11, 2021

Issue 58 (Recipe #64: Table of Contents for Multiple A/V Files on a Single Canvas)

+1: 20 [awead brndgtl cjnishioka cubap emulatingkat gigamorph glenrobson jonhartzler jtweed julsraemy ksclarke mcwhitaker mikeapp mixterj mposton-folger nfreire regisrob scossu triplingual zimeon glenrobson]
0: 0 []
-1: 0 []
Not TRC: 0 []
Ineligible: 2 [dismorfo jwd]

Result: 21 / 21 = 1.00

Super majority is in favor, issue is approved

@glenrobson
Copy link
Member Author

Maria reported the UV issue here: UniversalViewer/universalviewer#779 and it now looks to be working in the UV. So action now is to just remove the Mirador link.

@glenrobson glenrobson assigned glenrobson and unassigned mcwhitaker Dec 17, 2021
@glenrobson
Copy link
Member Author

It looks like 779 has now been fixed so we can add the UV back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants