Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IMU and Cam Recorder #327

Merged
merged 19 commits into from
Apr 13, 2022
Merged

Add IMU and Cam Recorder #327

merged 19 commits into from
Apr 13, 2022

Conversation

hungdche
Copy link
Member

Close #199.

  • Modify record_imu_cam plugin from this old branch so that it's compatible with current switchboard.

@hungdche hungdche added the feature New feature or request label Mar 15, 2022
@hungdche hungdche self-assigned this Mar 15, 2022
@mhuzai mhuzai changed the title Issue 199 add record imu cam paper Add IMU and Cam Recorder Mar 15, 2022
@mhuzai mhuzai requested review from mhuzai and qinjunj March 15, 2022 20:19
@mhuzai mhuzai added this to PRs in Progress in ILLIXR improvements via automation Mar 15, 2022
@mhuzai mhuzai modified the milestones: 2.x, 2.3 Mar 15, 2022
Copy link
Member

@mhuzai mhuzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. I left a few minor comments.

My main concern is the impact of the image writes on the rest of the system. It may not be significant, but we should check before merging this in. The way to do that would be to profile ILLIXR with data collection enabled using NSight Systems and seeing how much execution time, CPU utilization, etc. the cv::imwrites take.

configs/native.yaml Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
@charmoniumQ
Copy link
Member

My main concern is the impact of the image writes on the rest of the system. It may not be significant, but we should check before merging this in.

When we merge with the scheduling branch (specifically the merge item in #220), we will have a set_priority(...). Ideally, we could set_priority(...) this thread to a lower priority than the others.

record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
charmoniumQ
charmoniumQ previously approved these changes Apr 1, 2022
@charmoniumQ
Copy link
Member

Acceptance pursuant to this comment:

My main concern is the impact of the image writes on the rest of the system. It may not be significant, but we should check before merging this in. The way to do that would be to profile ILLIXR with data collection enabled using NSight Systems and seeing how much execution time, CPU utilization, etc. the cv::imwrites take.

Copy link
Member

@mhuzai mhuzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to profile cv::imwrite() to determine the performance hit, if any?

record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
@mhuzai mhuzai moved this from PRs in Progress to PRs in Review in ILLIXR improvements Apr 8, 2022
charmoniumQ
charmoniumQ previously approved these changes Apr 12, 2022
charmoniumQ
charmoniumQ previously approved these changes Apr 13, 2022
Copy link
Member

@mhuzai mhuzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some extraneous variables that can be removed now.

Also, we've made a lot of changes recently. Please test this branch once more before merging.

record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
record_imu_cam/plugin.cpp Outdated Show resolved Hide resolved
Copy link
Member

@mhuzai mhuzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you!

ILLIXR improvements automation moved this from PRs in Review to PRs Approved Apr 13, 2022
@mhuzai mhuzai merged commit 21832a1 into master Apr 13, 2022
ILLIXR improvements automation moved this from PRs Approved to Done Apr 13, 2022
mhuzai added a commit that referenced this pull request May 9, 2022
* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* Added documentation for using Switchboard and Phonebook externally (#320)

* Added documentation for using Switchboard and Phonebook externally

* fix typo and spacing

* Fix typos

Co-authored-by: Qinjun Jiang <90299267+qinjunj@users.noreply.github.com>

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* Fix and add documentation (#330)

* Add documentation for updating tags and documentation

* Set up using master instead of v2-latest

* Update doxygen project name

* Update Monado's main branch (they renamed 'master' to 'main')

* Fix typo in mkdocs.yml

* Update README with IISWC paper info

* Update bibtex

Co-authored-by: Sam Grayson <sam@samgrayson.me>

* Fix bibtex

Co-authored-by: Sam Grayson <sam@samgrayson.me>

* reponses to comments

* remove trailing space

* Add IMU and Cam Recorder (#327)

* Added record_imu_cam plugin

* Fixing fstream precision

* Adding data_record option for native.yaml

* Adding record_imu_cam plugin option

* Remove data_record.

* Fix minor issues

* Fix minor issues

* Used boost::filesystem instead of system

* Add lboost_filesystem flag

* Add the description for record_imu_cam

* Fix record_imu_cam path

* Fix boost filesystem operator

* Remove extra /

* Fix minor issues

* compute data paths using list initialization

* Fix minor issues and clean up extra variables

Co-authored-by: yingj4 <yingj4@illinois.edu>

* remove pose_lookup

* able to compile

* restore

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* wip

* Use relative clock in integrators

* Use relative clock in offload_data

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + rk4 works but its shakey)

* wip (ov + gtsam works)

* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* remove dummy integrator

* correct order of declaring

* suggested change to replace dataset_time

* Add Offloading VIO Plugins to ILLIXR (#331)

* Semi working with reader using callbacks

* Semi working with reader using sequential reads

* Semi working offloading. VIO doesnt work ATM

* test commit

* Add offloading server and device code

* Fixing common and adding extra prints for debugging

* Add prints and offloading config

* Server fix for zed pt1

* Offloading device cleanup

* Add offload client config

* Renamed files and merge master

* Cleaned up code ready for PR

* Fix readme

* Revert hotfix and address comments

* Revert rt_slam config

* Minor fix and verify all combinations of ZED/dataset with OV/Kimera work

* Address comments, add plugins to clean.yaml

* Add nproc back and update docs

* Typo

* Fix RealSense plugin (#337)

* Fix counter initialization and tidy up some code

* Properly initialize camera iteration count

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* wip

* Use relative clock in integrators

* Use relative clock in offload_data

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + rk4 works but its shakey)

* wip (ov + gtsam works)

* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + gtsam works)

* Wip (works with gtsam)

* Correct configs

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* disable debugview

* add declaration of NANO_SEC

* remove NANO_SEC

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* change back to size_t for imu_data loop

* enable debugview

* add back glfw3 for debugview

* remove dummy

* change back to size_t

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* suggested change to replace dataset_time

* respond to comments

* use relative clock in offload_vio

* respond to comments

* update distribution checking and warning msg for realsense

* Fix device_rx compilation

* Fix offload server config

* Resolve pending review comments

* update empty constructor of pose_type

* Update OV tag

* Update Kimera, OV, and Monado tags to reflect the usage of RelativeClock

* Update tags in offload-server

Co-authored-by: Giordano Salvador <73959795+e3m3@users.noreply.github.com>
Co-authored-by: Qinjun Jiang <qinjunj2@illinois.edu>
Co-authored-by: Jeffrey Zhang <23205149+JeffreyZh4ng@users.noreply.github.com>
Co-authored-by: Qinjun Jiang <90299267+qinjunj@users.noreply.github.com>
Co-authored-by: Muhammad Huzaifa <mhuzai@users.noreply.github.com>
Co-authored-by: Henry Che <90811347+hungdche@users.noreply.github.com>
Co-authored-by: yingj4 <yingj4@illinois.edu>
Co-authored-by: Muhammad Huzaifa <huzaifa2@illinois.edu>
shg8 pushed a commit to shg8/ILLIXR that referenced this pull request May 18, 2022
* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (ILLIXR#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* Added documentation for using Switchboard and Phonebook externally (ILLIXR#320)

* Added documentation for using Switchboard and Phonebook externally

* fix typo and spacing

* Fix typos

Co-authored-by: Qinjun Jiang <90299267+qinjunj@users.noreply.github.com>

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* Fix and add documentation (ILLIXR#330)

* Add documentation for updating tags and documentation

* Set up using master instead of v2-latest

* Update doxygen project name

* Update Monado's main branch (they renamed 'master' to 'main')

* Fix typo in mkdocs.yml

* Update README with IISWC paper info

* Update bibtex

Co-authored-by: Sam Grayson <sam@samgrayson.me>

* Fix bibtex

Co-authored-by: Sam Grayson <sam@samgrayson.me>

* reponses to comments

* remove trailing space

* Add IMU and Cam Recorder (ILLIXR#327)

* Added record_imu_cam plugin

* Fixing fstream precision

* Adding data_record option for native.yaml

* Adding record_imu_cam plugin option

* Remove data_record.

* Fix minor issues

* Fix minor issues

* Used boost::filesystem instead of system

* Add lboost_filesystem flag

* Add the description for record_imu_cam

* Fix record_imu_cam path

* Fix boost filesystem operator

* Remove extra /

* Fix minor issues

* compute data paths using list initialization

* Fix minor issues and clean up extra variables

Co-authored-by: yingj4 <yingj4@illinois.edu>

* remove pose_lookup

* able to compile

* restore

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* wip

* Use relative clock in integrators

* Use relative clock in offload_data

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + rk4 works but its shakey)

* wip (ov + gtsam works)

* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (ILLIXR#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* remove dummy integrator

* correct order of declaring

* suggested change to replace dataset_time

* Add Offloading VIO Plugins to ILLIXR (ILLIXR#331)

* Semi working with reader using callbacks

* Semi working with reader using sequential reads

* Semi working offloading. VIO doesnt work ATM

* test commit

* Add offloading server and device code

* Fixing common and adding extra prints for debugging

* Add prints and offloading config

* Server fix for zed pt1

* Offloading device cleanup

* Add offload client config

* Renamed files and merge master

* Cleaned up code ready for PR

* Fix readme

* Revert hotfix and address comments

* Revert rt_slam config

* Minor fix and verify all combinations of ZED/dataset with OV/Kimera work

* Address comments, add plugins to clean.yaml

* Add nproc back and update docs

* Typo

* Fix RealSense plugin (ILLIXR#337)

* Fix counter initialization and tidy up some code

* Properly initialize camera iteration count

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* wip

* Use relative clock in integrators

* Use relative clock in offload_data

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + rk4 works but its shakey)

* wip (ov + gtsam works)

* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (ILLIXR#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + gtsam works)

* Wip (works with gtsam)

* Correct configs

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* disable debugview

* add declaration of NANO_SEC

* remove NANO_SEC

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* change back to size_t for imu_data loop

* enable debugview

* add back glfw3 for debugview

* remove dummy

* change back to size_t

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* suggested change to replace dataset_time

* respond to comments

* use relative clock in offload_vio

* respond to comments

* update distribution checking and warning msg for realsense

* Fix device_rx compilation

* Fix offload server config

* Resolve pending review comments

* update empty constructor of pose_type

* Update OV tag

* Update Kimera, OV, and Monado tags to reflect the usage of RelativeClock

* Update tags in offload-server

Co-authored-by: Giordano Salvador <73959795+e3m3@users.noreply.github.com>
Co-authored-by: Qinjun Jiang <qinjunj2@illinois.edu>
Co-authored-by: Jeffrey Zhang <23205149+JeffreyZh4ng@users.noreply.github.com>
Co-authored-by: Qinjun Jiang <90299267+qinjunj@users.noreply.github.com>
Co-authored-by: Muhammad Huzaifa <mhuzai@users.noreply.github.com>
Co-authored-by: Henry Che <90811347+hungdche@users.noreply.github.com>
Co-authored-by: yingj4 <yingj4@illinois.edu>
Co-authored-by: Muhammad Huzaifa <huzaifa2@illinois.edu>
shg8 pushed a commit to shg8/ILLIXR that referenced this pull request May 18, 2022
* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (ILLIXR#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* Added documentation for using Switchboard and Phonebook externally (ILLIXR#320)

* Added documentation for using Switchboard and Phonebook externally

* fix typo and spacing

* Fix typos

Co-authored-by: Qinjun Jiang <90299267+qinjunj@users.noreply.github.com>

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* Fix and add documentation (ILLIXR#330)

* Add documentation for updating tags and documentation

* Set up using master instead of v2-latest

* Update doxygen project name

* Update Monado's main branch (they renamed 'master' to 'main')

* Fix typo in mkdocs.yml

* Update README with IISWC paper info

* Update bibtex

Co-authored-by: Sam Grayson <sam@samgrayson.me>

* Fix bibtex

Co-authored-by: Sam Grayson <sam@samgrayson.me>

* reponses to comments

* remove trailing space

* Add IMU and Cam Recorder (ILLIXR#327)

* Added record_imu_cam plugin

* Fixing fstream precision

* Adding data_record option for native.yaml

* Adding record_imu_cam plugin option

* Remove data_record.

* Fix minor issues

* Fix minor issues

* Used boost::filesystem instead of system

* Add lboost_filesystem flag

* Add the description for record_imu_cam

* Fix record_imu_cam path

* Fix boost filesystem operator

* Remove extra /

* Fix minor issues

* compute data paths using list initialization

* Fix minor issues and clean up extra variables

Co-authored-by: yingj4 <yingj4@illinois.edu>

* remove pose_lookup

* able to compile

* restore

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* wip

* Use relative clock in integrators

* Use relative clock in offload_data

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + rk4 works but its shakey)

* wip (ov + gtsam works)

* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (ILLIXR#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* remove dummy integrator

* correct order of declaring

* suggested change to replace dataset_time

* Add Offloading VIO Plugins to ILLIXR (ILLIXR#331)

* Semi working with reader using callbacks

* Semi working with reader using sequential reads

* Semi working offloading. VIO doesnt work ATM

* test commit

* Add offloading server and device code

* Fixing common and adding extra prints for debugging

* Add prints and offloading config

* Server fix for zed pt1

* Offloading device cleanup

* Add offload client config

* Renamed files and merge master

* Cleaned up code ready for PR

* Fix readme

* Revert hotfix and address comments

* Revert rt_slam config

* Minor fix and verify all combinations of ZED/dataset with OV/Kimera work

* Address comments, add plugins to clean.yaml

* Add nproc back and update docs

* Typo

* Fix RealSense plugin (ILLIXR#337)

* Fix counter initialization and tidy up some code

* Properly initialize camera iteration count

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* wip

* Use relative clock in integrators

* Use relative clock in offload_data

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + rk4 works but its shakey)

* wip (ov + gtsam works)

* Correct configs

* Fix sqlite

* Exorcise glfw3

* Rename classes

* Exorcise glfw3 (electric boogaloo)

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* Added '_m_dataset_first_time' in 'ground_truth_slam/plugin.cpp' (ILLIXR#58)

* disable debugview

* add condition

* remove -Werror in OPT-FLAGS

* copy common/debug.hpp from the scheduling branch

* add declaration of NANO_SEC

* use local monado

* remove NANO_SEC

* add absolute_ns but has error with +

* convert _m_start and relative to ns before adding them

* change name to passthrough_integrator and zeor out matrice

* comment conditions

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* use issue-58-standardize-clock branch in monado_integration

* change back to size_t for imu_data loop

* fix naming and spacing

* remove repeated synchronization

* enable debugview

* add back glfw3 for debugview

* added new line at EOF

* use offload_duration to be less confusing

* remove dummy

* change back to size_t

* update comments

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* Add stoplight to synchronize thread starts/stops

* Add missing file (the perils of -u instead of -A)

* Respond to reviewer comments

* Add documentation and comments

* Respond to reviewer comments

* Respond to reviewer comments

* Fix compile bugs

* Add stoplight to synchronize thread starts/stops

* Add relative clock to common and runtime

* Use relative clock in offline_imu_cam

* Use relative clock in gldemo (exorcise GLFW)

* Use relative clock in pose_*

* Use relative clock in timewarp

* Use relative clock in realsense and ZED

* Fix stuff

* wip

* Fix stuff

* wip

* Fix integrators

* wip (ov + dummy int works)

* wip (ov + gtsam works)

* Wip (works with gtsam)

* Correct configs

* Respond to reviewer comments

* Respond to reviewer comments

* Remove dataset_time

* disable debugview

* add declaration of NANO_SEC

* remove NANO_SEC

* removed dummy_integrator, changed to passthrough_integrator

* tests

* Started time_point

* create our own time_point

* change back to size_t for imu_data loop

* enable debugview

* add back glfw3 for debugview

* remove dummy

* change back to size_t

* synchronize after thread setup

* synchronize before p_thread_setup

* reponses to comments

* remove trailing space

* remove pose_lookup

* able to compile

* restore

* suggested change to replace dataset_time

* respond to comments

* use relative clock in offload_vio

* respond to comments

* update distribution checking and warning msg for realsense

* Fix device_rx compilation

* Fix offload server config

* Resolve pending review comments

* update empty constructor of pose_type

* Update OV tag

* Update Kimera, OV, and Monado tags to reflect the usage of RelativeClock

* Update tags in offload-server

Co-authored-by: Giordano Salvador <73959795+e3m3@users.noreply.github.com>
Co-authored-by: Qinjun Jiang <qinjunj2@illinois.edu>
Co-authored-by: Jeffrey Zhang <23205149+JeffreyZh4ng@users.noreply.github.com>
Co-authored-by: Qinjun Jiang <90299267+qinjunj@users.noreply.github.com>
Co-authored-by: Muhammad Huzaifa <mhuzai@users.noreply.github.com>
Co-authored-by: Henry Che <90811347+hungdche@users.noreply.github.com>
Co-authored-by: yingj4 <yingj4@illinois.edu>
Co-authored-by: Muhammad Huzaifa <huzaifa2@illinois.edu>
@hungdche hungdche deleted the issue-199-add-record_imu_cam-paper branch August 24, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Add record_imu_cam
4 participants