fix(login): disable buttons w/o session

This commit addresses two issues reported in #222:
 1. The duplicate text on the login panel has been removed.
 2. The tree cannot be expanded when the user does not have a session.

client/src/partials/bhima/application.js

@@ -24,9 +24,12 @@ function ApplicationController(AppCache, Session, Languages, $state, $rootScope,
   // the 'true' parameter forces refresh
   Languages.read(true);
 
-  vm.isLoggedIn = function isLoggedIn() {
+  vm.isLoggedIn = isLoggedIn;
+
+  // check if the user has a valid session.
+  function isLoggedIn() {
     return !!Session.user;
-  };
+  }
 
   // Default sidebar state
   /** @todo Load sidebar state before angular is bootstrapped to remove 'flicker' */
@@ -38,6 +41,7 @@ function ApplicationController(AppCache, Session, Languages, $state, $rootScope,
    * Application Structure methods
    */
   vm.toggleSidebar = function toggleSidebar() {
+    if (!isLoggedIn()) { return; }
     vm.sidebarExpanded = !vm.sidebarExpanded;
     cache.sidebar = { expanded : vm.sidebarExpanded };
   };
@@ -52,7 +56,9 @@ function ApplicationController(AppCache, Session, Languages, $state, $rootScope,
     delete vm.project;
   });
 
+  // go to the settings page
   vm.settings = function settings() {
+    if (!isLoggedIn()) { return; }
     $state.go('settings', { previous : $state.$current.name });
   };
 

client/src/partials/login/login.html

@@ -19,11 +19,12 @@
             </button>
             <ul role="menu" uib-dropdown-menu>
               <li role="menuitem" ng-repeat="(key, lang) in LoginCtrl.languages">
-                <a ng-click="LoginCtrl.languageService.set(key)">{{ lang.name }}</a>
+                <a ng-click="LoginCtrl.languageService.set(key)" href>
+                  {{ lang.name }}
+                </a>
               </li>
             </ul>
           </div>
-          <h4>{{ "LOGIN.TITLE" | translate }}</h4>
         </div>
 
         <div class="panel-body">

client/src/partials/login/login.js

@@ -2,8 +2,7 @@ angular.module('bhima.controllers')
 .controller('LoginController', LoginController);
 
 LoginController.$inject = [
-  'appcache', 'SessionService',
-  'LanguageService', 'ProjectService'
+  'appcache', 'SessionService', 'LanguageService', 'ProjectService'
 ];
 
 /**