fix(journal): right align edit modal footer

This commit right-aligns the currencies in the edit modal footer.
Third-Culture-Software · Sep 25, 2017 · 413f5af · 413f5af
1 parent a4a0c0e
commit 413f5af
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/.env.development b/.env.development
@@ -13,8 +13,8 @@ SESS_RESAVE=0
 SESS_UNSET='destroy'
 
 LOG_LEVEL='warn'
-# LOG_LEVEL='debug'
-UPLOAD_DIR='client/upload'
+LOG_LEVEL='debug'
+# UPLOAD_DIR='client/upload'
 
 # this will toggle all MYSQL errors to be reflected to the client.
 LOG_ALL_MYSQL_ERRORS=0

diff --git a/client/src/modules/journal/modals/editTransaction.modal.js b/client/src/modules/journal/modals/editTransaction.modal.js
@@ -54,6 +54,7 @@ function JournalEditTransactionController(
     field                            : 'debit_equiv',
     displayName                      : 'TABLE.COLUMNS.DEBIT',
     cellClass                        : 'text-right',
+    footerCellClass                 : 'text-right',
     headerCellFilter                 : 'translate',
     type : 'number',
     aggregationHideLabel : true,
@@ -64,6 +65,7 @@ function JournalEditTransactionController(
     field                            : 'credit_equiv',
     displayName                      : 'TABLE.COLUMNS.CREDIT',
     cellClass                        : 'text-right',
+    footerCellClass                 : 'text-right',
     headerCellFilter                 : 'translate',
     enableFiltering : true,
     type : 'number',

diff --git a/server/controllers/finance/journal/index.js b/server/controllers/finance/journal/index.js
@@ -568,15 +568,18 @@ function getTransactionDate(changedRows = {}, oldRows) {
  * @param {object} params - { uuids: [...], comment: '' }
  */
 function commentPostingJournal(req, res, next) {
-  const { params } = req.body;
-  const uuids = params.uuids.map(db.bid);
-
+  const { uids, comment } = req.body.params;
+  const uuids = uids.map(db.bid);
   const sql = 'UPDATE posting_journal SET comment = ? WHERE uuid IN ?';
-  db.exec(sql, [params.comment, [uuids]])
+
+  db.exec(sql, [comment, [uuids]])
     .then((rows) => {
-      if (!rows.affectedRows || rows.affectedRows !== uuids.length) {
-        throw new BadRequest('Error on update posting journal comment');
+      const updatedWithSuccess = rows.affectedRows && rows.affectedRows === uuids.length;
+
+      if (!updatedWithSuccess) {
+        throw new BadRequest('Error on update posting journal comment.');
       }
+
       res.sendStatus(200);
     })
     .catch(next)