Skip to content

Commit

Permalink
fix(trial balance): incorrect button text
Browse files Browse the repository at this point in the history
This commit fixes the incorrect button text on the trial balance
reported in #908.  The text reads "View Details" instead of "View
Errors", since it shows the details of each account hit instead of the
details of errors associated with the accounts.

Closes #908.
  • Loading branch information
Jonathan Niles authored and sfount committed Nov 23, 2016
1 parent 622056e commit 733a57a
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 10 deletions.
7 changes: 4 additions & 3 deletions client/src/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -322,12 +322,13 @@
"UPDATE_PASSWORD" : "Update Password",
"UPDATE" : "Update",
"VALIDATE" : "Validate",
"VIEW_ERRORS" : "View Errors"
"VIEW_ERRORS" : "View Errors",
"VIEW_DETAILS" : "View Details"
},
"DIALOGS": {
"CONFIRM_ACTION" : "Do you confirm this action ?",
"CONFIRM_ACTION" : "Do you confirm this action?",
"CONFIRM_DELETE" : "You are about to delete a record. This action is permanent and cannot be undone. Click \"Confirm\" to accept or \"Cancel\" to halt this action.",
"CANNOT_UNDONE_ACTION" : "This action CANNOT BE REVERSED, this action will be permanent. You must be sure that you want to do this action",
"CANNOT_UNDONE_ACTION" : "This action CANNOT BE REVERSED, the action will be permanent. You must be sure that you want to do this action.",
"NO_CORRESPONDANCY" : "No correspondancy found for ",
"PLEASE_TYPE_TEXT" : "Please type {{value}} to confirm",
"PLEASE_READ" : "Unexpected bad things will happen if you don't read this!",
Expand Down
3 changes: 2 additions & 1 deletion client/src/i18n/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@
"UPDATE_PASSWORD" : "Modifier mot de passe",
"UPDATE" : "Mettre à jour",
"VALIDATE" : "Valider",
"VIEW_ERRORS" : "Voir erreurs"
"VIEW_ERRORS" : "Voir Erreurs",
"VIEW_DETAILS" : "Voir les Détails"
},
"DIALOGS": {
"CONFIRM_ACTION" : "Confirmez vous cette action ?",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function TrialBalanceMainBodyController(Session, trialBalanceService, Grouping,
headerCellFilter: 'translate',
visible: true,
enableCellEdit: false,
cellTemplate: '/partials/journal/templates/error-link.cell.html',
cellTemplate: '/partials/journal/templates/details-link.cell.html',
allowCellFocus: false
}
];
Expand Down
5 changes: 5 additions & 0 deletions client/src/partials/journal/templates/details-link.cell.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<div class="ui-grid-cell-contents">
<a href data-method="detail" ng-click="grid.appScope.viewDetailByAccount(row.entity.account_id)" class="text-info">
<i class="fa fa-info-circle"></i> {{ "FORM.BUTTONS.VIEW_DETAILS" | translate }}
</a>
</div>
5 changes: 0 additions & 5 deletions client/src/partials/journal/templates/error-link.cell.html

This file was deleted.

0 comments on commit 733a57a

Please sign in to comment.