Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Complex Voucher ui-grids do not have loading indicators #1127

Closed
jniles opened this issue Feb 6, 2017 · 1 comment · Fixed by #1155
Closed

(bug) Complex Voucher ui-grids do not have loading indicators #1127

jniles opened this issue Feb 6, 2017 · 1 comment · Fixed by #1155
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 6, 2017

In the complex vouchers page, the ui-grids that load invoices, vouchers, or cash payments do not have loading indicators. This leads to a broken-looking application for a second. I recommend that all the grids be reviewed to make sure they have bhGridLoadingIndicators in place.

vouchersgridnoloadingindicators
Fig 1: Broken-Looking Grid Loading Thousands of Invoices
@jniles jniles added the Bug label Feb 6, 2017
@sfount sfount mentioned this issue Feb 8, 2017
Closed
@jniles jniles self-assigned this Feb 9, 2017
@jniles
Copy link
Collaborator Author

jniles commented Feb 9, 2017

I'll take this one.

@jniles jniles mentioned this issue Feb 9, 2017
Closed
jniles pushed a commit to jniles/bhima that referenced this issue Feb 9, 2017
fix(vouchers): bug/UX fixes on findReference Modal
4d56107 
This commit fixes usability issues on the findReference modal.
  1. Makes the header an `<ol>` headercrumb
  2. Uses the `translate` directive
  3. Adds a loading indicator to the grid.
  4. Makes sure the reference identifier is clearly visible in grid.

Closes Third-Culture-Software#1127. Closes 1139.
@jniles jniles mentioned this issue Feb 9, 2017
Merged
4 tasks
sfount pushed a commit that referenced this issue Feb 10, 2017
@sfount
fix(vouchers): bug/UX fixes on findReference Modal
063e8d9 
This commit fixes usability issues on the findReference modal.
  1. Makes the header an `<ol>` headercrumb
  2. Uses the `translate` directive
  3. Adds a loading indicator to the grid.
  4. Makes sure the reference identifier is clearly visible in grid.

Closes #1127. Closes 1139.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(vouchers): bug/UX fixes on findReference Modal jniles/bhima
1 participant
@jniles