Edit journal entity #1511
Merged
Edit journal entity #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
reviewed
Apr 17, 2017
| _.each(result, (row, uid) => transaction.addQuery(UPDATE_JOURNAL_ROW, [row, db.bid(uid)])); | ||
| _.each(result, (row, uid) => { | ||
| db.convert(row, ['entity_uuid']); | ||
| return transaction.addQuery(UPDATE_JOURNAL_ROW, [row, db.bid(uid)]); |
There was a problem hiding this comment.
You do not need this return here.
| @@ -307,15 +307,18 @@ function editTransaction(req, res, next) { | |||
| transformColumns(rowsAdded, true) | |||
| .then((result) => { | |||
| result.forEach((row) => { | |||
| db.convert(row, ['uuid', 'record_uuid']); | |||
| db.convert(row, ['uuid', 'record_uuid', 'entity_uuid']); | |||
| * @public | ||
| * | ||
| */ | ||
| Transactions.prototype.editCellGrid = function editCellGrid(rowEntity, field, value) { |
There was a problem hiding this comment.
Can you make this function the same function as editCell? It looks duplicated. And if it must be a different function, can this just call editCell internally?
|
☔ The latest upstream changes (presumably 2b2435d) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@mbayopanda, whoops.... sorry about that :( |
mbayopanda
force-pushed
the
edit_journal_entity
branch
from
8b4602e
to
363ed3a
Compare
|
@kwilu try |
ghost
pushed a commit
that referenced
this pull request
Apr 19, 2017
Edit journal entity This PR add the option of editing the entity of transactions in the posting journal.
|
@kwilu try |
|
@mbayopanda: 🔑 Insufficient privileges: Not in reviewers |
update transaction service Fix and enhancement Fix $digest error and enhancement Fix issues from review
ghost
pushed a commit
that referenced
this pull request
Apr 19, 2017
Edit journal entity This PR add the option of editing the entity of transactions in the posting journal.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the option of editing the entity of transactions in the posting journal.