fix(journal): ensure that data callbacks disable cellNav #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jniles
force-pushed
the
feature-single-click-edit-posting-journal
branch
from
ee729a6
to
f3a72cb
Compare
|
@kwilu r+ |
|
📌 Commit f3a72cb has been approved by |
ghost
pushed a commit
that referenced
this pull request
Apr 18, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
|
@kwilu clean |
|
💥 Test timed out |
ghost
pushed a commit
that referenced
this pull request
Apr 19, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
|
@kwilu rollup |
ghost
pushed a commit
that referenced
this pull request
Apr 19, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
jniles
force-pushed
the
feature-single-click-edit-posting-journal
branch
from
f3a72cb
to
26c459c
Compare
This commit makes sure that the Posting Journal's datachange callbacks are run after the columns are modified. Closes Third-Culture-Software#1495.
jniles
force-pushed
the
feature-single-click-edit-posting-journal
branch
from
26c459c
to
478b6aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are
modified.
Closes #1495. Addresses #1500.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!