Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of cancel Button on the Debtor Groups Page #1527

Merged
merged 2 commits into from
Apr 20, 2017

Conversation

lomamech
Copy link
Collaborator

Implementation of cancel Button on the Debtor Groups Page

closes #1125

@lomamech lomamech requested a review from jniles April 20, 2017 07:39
@@ -77,6 +78,10 @@ function DebtorGroupsUpdateController($state, DebtorGroups, Accounts, Prices, Sc
.catch(Notify.handleError);
}

function cancel(){
$state.go('debtorGroups.list', null, {reload : true});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the reload:true here? Or does it work okay without it?

@jniles
Copy link
Collaborator

jniles commented Apr 20, 2017

LGTM!

@jniles jniles merged commit 0a708fb into Third-Culture-Software:master Apr 20, 2017
@lomamech lomamech deleted the cancelButtonDebtGroup branch May 15, 2017 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature request): implement a cancel button on the debtor groups page
2 participants