Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding id and data-method attributes in breadcrumb #157

Merged

Conversation

mbayopanda
Copy link
Collaborator

This PR add id and data-method attributes for selecting elements in the breadcrumb directive

@mbayopanda
Copy link
Collaborator Author

@jniles could you review this PR

@jniles
Copy link
Collaborator

jniles commented Mar 2, 2016

LGTM. Once the tests pass, I'll merge this.

jniles added a commit that referenced this pull request Mar 2, 2016
Adding id and data-method attributes in breadcrumb
@jniles jniles merged commit b089cb1 into Third-Culture-Software:master Mar 2, 2016
@mbayopanda mbayopanda deleted the directive_breadcrumb branch September 14, 2016 08:54
jniles referenced this pull request in jniles/bhima Jan 29, 2017
This commit updates account management to use the loading button on the
form for creating and updating accounts.  It also favors the translate
directive over the filter.

Closes #157.
jniles referenced this pull request in jniles/bhima Jan 30, 2017
This commit updates account management to use the loading button on the
form for creating and updating accounts.  It also favors the translate
directive over the filter.

Closes #157.
jniles referenced this pull request in jniles/bhima Jan 30, 2017
This commit updates account management to use the loading button on the
form for creating and updating accounts.  It also favors the translate
directive over the filter.

Closes #157.
jniles referenced this pull request in jniles/bhima Jan 30, 2017
This commit updates account management to use the loading button on the
form for creating and updating accounts.  It also favors the translate
directive over the filter.

Closes #157.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants