Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) Clicking outside the Journal Filters modal closes the modal #1617

Closed
jniles opened this issue May 8, 2017 · 1 comment · Fixed by #1624
Closed

(bug) Clicking outside the Journal Filters modal closes the modal #1617

jniles opened this issue May 8, 2017 · 1 comment · Fixed by #1624
Assignees
Labels

Comments

@jniles
Copy link
Collaborator

jniles commented May 8, 2017

The Journal Filters modal is hard to use to inexperienced users because it closes when clicking on the backdrop. This makes it hard for them to get out of a typeahead or ui-select without closing the modal and losing all their work.

Adding backdrop: 'static' to the modal should fix it.

@jniles jniles added the Bug label May 8, 2017
@jniles jniles self-assigned this May 8, 2017
@jniles
Copy link
Collaborator Author

jniles commented May 8, 2017

I'll take this one.

jniles added a commit to jniles/bhima that referenced this issue May 8, 2017
This commit fixes a usability issue that would automatically close the Journal Search modal when a
user clicked outside of it.  Users often clicked outside the search modal to try and dismiss a
dropdown, but ended up dismissing the entire modal.  Operating on the princple of least surprise
(and least frustration), the dismiss-on-external-click has been removed.

Closes Third-Culture-Software#1617.
jniles added a commit to jniles/bhima that referenced this issue May 9, 2017
This commit fixes a usability issue that would automatically close the Journal Search modal when a
user clicked outside of it.  Users often clicked outside the search modal to try and dismiss a
dropdown, but ended up dismissing the entire modal.  Operating on the princple of least surprise
(and least frustration), the dismiss-on-external-click has been removed.

Closes Third-Culture-Software#1617.
jniles added a commit to jniles/bhima that referenced this issue May 19, 2017
This commit fixes a usability issue that would automatically close the Journal Search modal when a
user clicked outside of it.  Users often clicked outside the search modal to try and dismiss a
dropdown, but ended up dismissing the entire modal.  Operating on the princple of least surprise
(and least frustration), the dismiss-on-external-click has been removed.

Closes Third-Culture-Software#1617.
jniles added a commit to jniles/bhima that referenced this issue May 23, 2017
This commit fixes a usability issue that would automatically close the Journal Search modal when a
user clicked outside of it.  Users often clicked outside the search modal to try and dismiss a
dropdown, but ended up dismissing the entire modal.  Operating on the princple of least surprise
(and least frustration), the dismiss-on-external-click has been removed.

Closes Third-Culture-Software#1617.
sfount pushed a commit that referenced this issue May 23, 2017
This commit fixes a usability issue that would automatically close the Journal Search modal when a
user clicked outside of it.  Users often clicked outside the search modal to try and dismiss a
dropdown, but ended up dismissing the entire modal.  Operating on the princple of least surprise
(and least frustration), the dismiss-on-external-click has been removed.

Closes #1617.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant