-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(error) Landing page details #1675
Labels
Comments
The error is because this line: const dbPromise = [db.exec(sqlInvoices, [date, date]), db.exec(sqlBalance, [date, date])]; Should be const dbPromise = [db.exec(sqlInvoices, [date, date, date, date]), db.exec(sqlBalance, [date, date, date, date])]; |
Also, the |
I'll take this. |
jniles
added a commit
to jniles/bhima
that referenced
this issue
May 24, 2017
This commit fixes a bug in the dashboard which previously didn't template in all the correct dates. It also improves the performance slightly be removing a JOIN between voucher and invoices. Closes Third-Culture-Software#1675.
4 tasks
jniles
added a commit
to jniles/bhima
that referenced
this issue
May 25, 2017
This commit fixes a bug in the dashboard which previously didn't template in all the correct dates. It also improves the performance slightly be removing a JOIN between voucher and invoices. Closes Third-Culture-Software#1675.
bors bot
added a commit
that referenced
this issue
May 25, 2017
1678: fix(stats): template in all dates for dashboard r=jniles This commit fixes a bug in the dashboard which previously didn't template in all the correct dates. It also improves the performance slightly be removing a JOIN between voucher and invoices. Closes #1675. ------ Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is an error on the landing page details :
The text was updated successfully, but these errors were encountered: