(bug) Trial Balance UI Errors + Exporter #1680
Assignees
Labels
Comments
|
I'll pick this one up. |
jniles
added a commit
to jniles/bhima
that referenced
this issue
May 30, 2017
This commit fixes the alignment bugs in the exporter and error buttons. It also makes the exporter button a normal button, instead of a "success" button. Closes Third-Culture-Software#1680.
jniles
added a commit
to jniles/bhima
that referenced
this issue
May 30, 2017
This commit fixes the alignment bugs in the exporter and error buttons. It also makes the exporter button a normal button, instead of a "success" button. Closes Third-Culture-Software#1680.
4 tasks
bors bot
added a commit
that referenced
this issue
May 31, 2017
1701: fix(trialBalance): align exporter/error buttons r=jniles This commit fixes the alignment bugs in the exporter and error buttons. It also makes the exporter button a normal button, instead of a "success" button. Closes #1680. ------ Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
jniles
changed the title
bors bot
added a commit
that referenced
this issue
May 31, 2017
1690: refactor(users): make activate/deactivate red r=jniles This commit changes the user activate/deactivate to a red color and puts it under a divider to indicate that it's a stronger action than the other options. --- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks! 1701: fix(trialBalance): align exporter/error buttons r=jniles This commit fixes the alignment bugs in the exporter and error buttons. It also makes the exporter button a normal button, instead of a "success" button. Closes #1680. ------ Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Trial Balance "Exporter" button and "View Errors" buttons do not play well together. See below:
Fig 1: View Errors and Exporter Buttons shift modal size
This should be corrected so that the two are on the same line.
The text was updated successfully, but these errors were encountered: