Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement State Based Router #206

Closed
sfount opened this issue Mar 23, 2016 · 1 comment
Closed

Implement State Based Router #206

sfount opened this issue Mar 23, 2016 · 1 comment
Assignees
@jniles
Labels
design

Comments

@sfount
Copy link
Contributor

sfount commented Mar 23, 2016

The need for correctly handling state in application modules has been recorded for a while - #51.

At this point many configuration (management modules) have been developed and is essential that a good standard for how to proceed with module routing is developed. There are many reviews on code that notice a weakness in state management.

Routing should either be implemented with UI-Router or Component Router (towards Angular 2); with a proof of concept implemented as soon as possible.

Suggested course of action:

  1. Module is selected for proof of concept implementation
  2. Module is developed using the new utility (UI Router/ Component Router)
  3. Code is reviewed
  4. Once the code is merged into master a wiki article defines exactly how to handle state in an application module and this is then used to measure future code merge requests.
    @IMA-WorldHealth/local-contributors
@sfount sfount added this to the 2.x Process milestone Mar 23, 2016
@jniles jniles self-assigned this Mar 23, 2016
@jniles
Copy link
Collaborator

jniles commented Mar 23, 2016

I'm on it.

jniles referenced this issue in jniles/bhima Mar 29, 2016
@jniles
feat(billing services): delete modal + deep link
bb1c575 
This commit adds the ability to deep link deletes via ui-router's state.
Delete now operates like update, using `/billing_services/:id/delete` to
open a generic delete modal to perform the delete request.

This commit completes the functionality of the billing_services module.
However, it needs polishing.  A review issue will be made to mention the
following things specfically:
 1. Bad Delete Modal UI - this should be improved as we use it in
 multiple places.
 2. The "create" button is in a terribly chosen place - should this be a
 dropdown?
 3. (Server) error handling needs to be decided on and adopted by the
 whole team uniformly.
 4. Better alert system (scroll to and highlight) for ui-grid on create
 and update.

 This commit officially closes #206.
jniles referenced this issue in jniles/bhima Mar 29, 2016
@jniles
feat(billing services): delete modal + deep link
b01729b 
This commit adds the ability to deep link deletes via ui-router's state.
Delete now operates like update, using `/billing_services/:id/delete` to
open a generic delete modal to perform the delete request.

This commit completes the functionality of the billing_services module.
However, it needs polishing.  A review issue will be made to mention the
following things specfically:
 1. Bad Delete Modal UI - this should be improved as we use it in
 multiple places.
 2. The "create" button is in a terribly chosen place - should this be a
 dropdown?
 3. (Server) error handling needs to be decided on and adopted by the
 whole team uniformly.
 4. Better alert system (scroll to and highlight) for ui-grid on create
 and update.

 This commit officially closes #206.
jniles referenced this issue in jniles/bhima Mar 29, 2016
@jniles
feat(billing services): delete modal + deep link
2d98d3b 
This commit adds the ability to deep link deletes via ui-router's state.
Delete now operates like update, using `/billing_services/:id/delete` to
open a generic delete modal to perform the delete request.

This commit completes the functionality of the billing_services module.
However, it needs polishing.  A review issue will be made to mention the
following things specfically:
 1. Bad Delete Modal UI - this should be improved as we use it in
 multiple places.
 2. The "create" button is in a terribly chosen place - should this be a
 dropdown?
 3. (Server) error handling needs to be decided on and adopted by the
 whole team uniformly.
 4. Better alert system (scroll to and highlight) for ui-grid on create
 and update.

 This commit officially closes #206.
@sfount sfount closed this as completed in ecee32f Mar 31, 2016
@jniles jniles mentioned this issue Aug 26, 2016
Closed
jniles referenced this issue in jniles/bhima Jan 30, 2017
@jniles
Merge pull request #206 from sfount/fix-trial-balance-posting
1603ec4 
fix(trial_balance) use POST for large params
bors bot added a commit that referenced this issue Aug 26, 2018
@bors @greenkeeper
Merge #3082
c234a89 
3082: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]




## Version **1.94.0** of **snyk** was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </th>
    <td>
      <a target=_blank href=https://github.com/snyk/snyk>snyk</a>
    </td>
  </tr>
  <tr>
      <th align=left>
       Current Version
      </th>
      <td>
        1.92.7
      </td>
    </tr>
  <tr>
    <th align=left>
      Type
    </th>
    <td>
      dependency
    </td>
  </tr>
</table>



The version **1.94.0** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of snyk.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Release Notes</summary>
<strong>v1.94.0</strong>

<h1><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.93.0...v1.94.0">1.94.0</a> (2018-08-26)</h1>
<h3>Features</h3>
<ul>
<li>add more tracing info on docker entrypoint (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/979fe5d">979fe5d</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 4 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/174217b2078239b04ba84b3e76398dcc01c5da37"><code>174217b</code></a> <code>Merge pull request #209 from snyk/feat/tracing_info_on_docker_entry</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/979fe5dd3cefa600c76f02b0cd27919554a6f7d9"><code>979fe5d</code></a> <code>feat: add more tracing info on docker entrypoint</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/16929f39da1875c58be39e30d4a052057eed4b90"><code>16929f3</code></a> <code>Merge pull request #206 from snyk/feat/add_debug_info_on_docker</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/716ea3ecb43ea3d4a8fe7ff3c1569ce95a57db37"><code>716ea3e</code></a> <code>feat: add debugging info on docker entrypoint</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/6eeface5ea0b9e976ef658408c990b80fb276aba...174217b2078239b04ba84b3e76398dcc01c5da37">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount