Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The exchange rate modal should show the current exchange rate #2387

Closed
jniles opened this issue Dec 11, 2017 · 1 comment
Closed

The exchange rate modal should show the current exchange rate #2387

jniles opened this issue Dec 11, 2017 · 1 comment
Assignees
@jniles
Labels
client request

Comments

@jniles
Copy link
Collaborator

jniles commented Dec 11, 2017

It's useful to have the current exchange rate on the exchange rate modal for reference. We should put the "current rate" somewhere on the modal for the user to refer to when making any changes.
@jniles jniles self-assigned this Dec 14, 2017
@jniles
Copy link
Collaborator Author

jniles commented Dec 14, 2017

I'll tackle this one.

jniles added a commit to jniles/bhima that referenced this issue Jan 15, 2018
@jniles
feat(exchange): add the current exchange rate
468a134 
This commit adds the current exchange rate to the exchange rate modal
for reference.  This feature was requested by our clients at HEV.

Closes Third-Culture-Software#2387.
@jniles jniles mentioned this issue Jan 15, 2018
Merged
bors bot added a commit that referenced this issue Jan 19, 2018
@bors
Merge #2454 #2455
6aa97c3 
2454: feat(exchange): add the current exchange rate r=jniles a=jniles

This commit adds the current exchange rate to the exchange rate modal
for reference.  This feature was requested by our clients at HEV.

![exchangerateupdates](https://user-images.githubusercontent.com/896472/34944109-92731706-f9fe-11e7-9ec6-a208c434bf81.PNG)
_Fig 1: Show Exchange Rate on Modal_

Closes #2387.

2455: fix(General Ledger): identify title accounts r=jniles a=jniles

This commit fixes the general ledger by rendering the title accounts in bold and removing the option to download their account slips.  I've also optimized the GL by removing dead code and using ui-grid's native tools instead of multiple cell templates.

![titleaccountbold](https://user-images.githubusercontent.com/896472/34944090-80d30cae-f9fe-11e7-9b4a-07a5ca9da92c.PNG)
_Fig 1: Example of Bold Titles_

Closes #2348.
@bors bors bot closed this as completed in #2454 Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
client request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jniles