Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links from the General Ledger to the Account Statement #2459

Closed
jniles opened this issue Jan 19, 2018 · 0 comments
Closed

Add links from the General Ledger to the Account Statement #2459

jniles opened this issue Jan 19, 2018 · 0 comments
Assignees

Comments

@jniles
Copy link
Collaborator

jniles commented Jan 19, 2018

The General Ledger currently only has a single link "Extrait de Compte". This links to a PDF report of the account transactions for the month.

Another link that would be helpful is a link to the Account Statement filtered on that account, allowing a user to explore the transactions hitting that account, with the power of viewing all the details directly from this link. Since the GL only contains posted values, it does not need to link to the Journal as well.

@jniles jniles self-assigned this Jan 26, 2018
jniles added a commit to jniles/bhima that referenced this issue Jan 26, 2018
This commit links the General Ledger to the Account Statement via the
dropdown menu in the General Ledger.

Closes Third-Culture-Software#2459.
jniles added a commit to jniles/bhima that referenced this issue Jan 26, 2018
This commit links the General Ledger to the Account Statement via the
dropdown menu in the General Ledger.

Closes Third-Culture-Software#2459.
bors bot added a commit that referenced this issue Jan 29, 2018
2462: Refactor General Ledger r=mbayopanda a=jniles

This PR refactors the General Ledger to make it more useful from an accounting perspective.

**Code Refactor**
 1. The server-side SQL query has been rewritten to be more performant and easier to read.  In particular, the WHERE query filters on fiscal year instead of first looking up the periods in the fiscal year.
 2. Removed the Account Slip code - it was essentially a duplication of effort from the Account Statement code.
 3. Renamed all variables references `general-ledger-accounts` to `general-ledger`.  We had folded the previous "General Ledger" into the Journal, so only this one remains.

**Features**
 1. A `<select>` element to the grid footer to use to switch the fiscal year and removes the Fiscal Year modal.  This was requested by @WayneNiles and improves the UX by allowing users to switch fiscal years on the fly.  By removing the modal, we also alleviate the maintenance burden on developers.
 2. A "check row" at the bottom of the General Ledger has been implemented, showing the sum of each column with period balances.  _These columns should always sum to zero_.  If not, it means that there is an imbalanced transaction somewhere.
 3. Title accounts are now show and hold the sum of the balances of their children.  This allows a really quick comparison of bulk amounts, such as Income versus Expense.  This has been implemented using a `Tree` class, available to be used in other reports.
 4. Added title account highlighting and indentation to both the client and server-side generated reports for the General Ledger.  The indentation is set to `15px` by default.
 5. Add a link to the Account Statement module.  This allows a user to directly inspect the values from the General Ledger in the Account Statement.

**Screenshots**
![newgl](https://user-images.githubusercontent.com/896472/35456000-5a04432a-02d4-11e8-812d-760446e3a6ae.PNG)
_Fig 1: New General Ledger Client_

![newglreport](https://user-images.githubusercontent.com/896472/35456057-8e33d76e-02d4-11e8-8418-db15de5c8195.PNG)
_Fig 2: New General Ledger Report w/ Indentation_


 Closes #1706.  Closes #2459.  Closes #2463. Closes #2373.
@bors bors bot closed this as completed in #2462 Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant