Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sum the debit (source) and credit (source) columns in the Journal #2512

Closed
jniles opened this issue Feb 3, 2018 · 0 comments · Fixed by #2514
Closed

Sum the debit (source) and credit (source) columns in the Journal #2512

jniles opened this issue Feb 3, 2018 · 0 comments · Fixed by #2514
Assignees
@jniles
Labels
Feature Request

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 3, 2018

In the Journal, the debit/credit columns are summed and their values displayed both on the transaction headers and the footer of the grid. We should also sum the debit (source) and credit (source) columns, but only render there values on the transaction header where it makes sense.

To do this, you will likely have to hide the grid footer column's value. This is easy - just set the footer template to some empty HTML, like <i></i>. Other than that, it should be the same as the regular debit/credit columns.
@jniles jniles self-assigned this Feb 5, 2018
jniles added a commit to jniles/bhima that referenced this issue Feb 5, 2018
@jniles
feat(journal): add debit/credit source sums
a9771a3 
This commit adds summation on the debit/credit source columns of the
journal and Account Statement.

Closes Third-Culture-Software#2512.
@jniles jniles mentioned this issue Feb 5, 2018
Merged
jniles added a commit to jniles/bhima that referenced this issue Feb 8, 2018
@jniles
feat(journal): add debit/credit source sums
27f4eeb 
This commit adds summation on the debit/credit source columns of the
journal and Account Statement.

Closes Third-Culture-Software#2512.
bors bot added a commit that referenced this issue Feb 8, 2018
@bors
Merge #2514
1287f2a 
2514: feat(journal): add debit/credit source sums r=jniles a=jniles

This commit adds summation on the debit/credit source columns of the Journal and Account Statement.  It also makes both files pass ESLint.

![fixedaggregategroupingjournal](https://user-images.githubusercontent.com/896472/35802144-3e515422-0a6f-11e8-8eb1-3122aee0a782.PNG)
_Fig 1: End Result on Journal_


Closes #2512.
@bors bors bot closed this as completed in #2514 Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(journal): add debit/credit source sums jniles/bhima
1 participant
@jniles