fix: broke ${id} references in template strings #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does two things:
1. Fixes broken ${} parameter passing in the template strings for error
messages.
2. Wraps the session's enterprise selection in `BUID(e.location_id)` so
that it isn't sent as binary to the client.
jniles
force-pushed
the
chore-remove-broken-id-references
branch
from
c1b18aa
to
a94ccde
Compare
|
@sfount, could I get a code review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does two things:
${}parameter passing in the template strings for error messages.BUID(e.location_id)so that it isn't sent as binary to the client.Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist
that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process
and help build a stronger application. Thanks!