feat(components): add ui-grid loading indicator #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `bhGridLoadingIndicator`, a component that shows nice
messages on loading states, empty states, and error states. The basic
usage looks like this:
```html
<div ui-grid>
<bh-grid-loading-indicator
loading-state="Ctrl.loading"
empty-state="Ctrl.grid.data.length === 0"
error-state="Ctrl.hasError">
</bh-grid-loading-indicator>
</div>
```
The `hasError` state takes precedence over all other states - if this
value is `true`, it will not show any of the other loading indicators,
even if data has loaded or is loading. The message is very generic -
one is expected to report the proper error using `Notify.danger()` or
`Notify.handleError()`.
For a real example, see the billing services module and patient
registry.
|
Everything LGTM. The simplicity of this component might make it a good start for adding more unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
bhGridLoadingIndicator, a component that shows nice messages on loading states, empty states, and error states. The basic usage looks like this:The
hasErrorstate takes precedence over all other states - if this value istrue, it will not show any of the other loading indicators, even if data has loaded or is loading. The message is very generic - one is expected to report the proper error usingNotify.danger()orNotify.handleError().For a real example, see the billing services module and patient registry.
Screen Shots
Fig 1. Grid Error State
Fig 2. Grid Loading State
Fig 3. Empty Grid State
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!