Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): add moment to npm dependencies #453

Merged
merged 2 commits into from
May 30, 2016

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented May 30, 2016

This commit resolves errors in the master branch by using a npm installed version of moment instead of the bower installed version on the server side.

Requires npm install and bower install.


Thank you for contributing!

Before submitting this pull request, please verify that you have:

  • Run your code through JSHint. Check out our styleguide.
  • Run integration tests.
  • Run end-to-end tests.
  • Accurately described the changes your are making in this pull request.

For a more detailed checklist, see the official review checklist that this PR will be evaluated against.

Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!

This commit resolves errors in the master branch by using a npm
installed version of moment instead of the bower installed version on
the server side.
This commit bumps the versions of angular and dependencies found in the
bower modules.  It attempts to fix the breaks on master.
@jniles
Copy link
Collaborator Author

jniles commented May 30, 2016

Code is up to standards set in the PR standards document. Report any bugs that might have been introduced to this thread and it will be reverted.

@jniles jniles merged commit a1ad53d into Third-Culture-Software:master May 30, 2016
@jniles jniles deleted the fix-vendor-moment branch May 30, 2016 09:58
@jniles jniles mentioned this pull request May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant