Transferts API and Integration test #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,6 +67,7 @@ var caution = require('../controllers/categorised/caution'); | |||
| var employees = require('../controllers/categorised/employees'); | |||
| var subsidies = require('../controllers/categorised/subsidies'); | |||
| var units = require('../controllers/units'); | |||
| var transferts = require('../controllers/finance/transferts'); | |||
There was a problem hiding this comment.
Transferts is a French name. Could you rename this Transfers?
|
@mbayopanda, I've given an initial review. Here are some important fixes:
I think we need to discuss as a team the design of the transfer module + API. It seems to me that transfers might be better put within a cashbox API rather than just a raw |
|
@mbayopanda |
mbayopanda
force-pushed
the
api_transferts
branch
from
21dd182
to
d8babf0
Compare
|
LGTM. |
jniles
added a commit
that referenced
this pull request
Feb 1, 2016
Transferts API and Integration test
jniles
referenced
this pull request
in jniles/bhima
Jan 4, 2017
* fix(form): disabled autocomplete, autocorrect, etc This commit attempts to fix the forms in the application to no longer provide autocomplete options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR :
Add an API endpoint for transferts module
Contains an integration test for transferts API
Note :
This API doesnt contains entries for delete and update :
Delete : not a priority now
Update : we must deal with posting journal which can be more difficult to handle