Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Purchase Orders broken #726

Closed
jniles opened this issue Sep 14, 2016 · 2 comments
Closed

(bug) Purchase Orders broken #726

jniles opened this issue Sep 14, 2016 · 2 comments
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Sep 14, 2016

For some reason, the ui-grid-cellNav on the Purchase Orders page has made the grid uneditable. I propose we remove the ui-grid-cellNav feature - it doesn't really have a use anyway.

Steps to Reproduce

  1. Go to /purchase/create
  2. Enter any supplier
  3. Attempt to fill in the first inventory item.

Expected Result
Inventory items should show up in a typeahead.

Actual Result
The input cannot be selected since the cellNav captures all the inputs.
@jniles jniles added the Bug label Sep 14, 2016
@jniles jniles added this to the Inventory Management Implementation milestone Sep 14, 2016
@DedrickEnc
Copy link
Contributor

DedrickEnc commented Sep 14, 2016 •
edited
Loading

You suggestion works for me.
Why our end to end test did not prevent bugs?

@jniles
Copy link
Collaborator Author

jniles commented Sep 14, 2016

I'm not sure... I'll investigate after #694 is in.

jniles pushed a commit to jniles/bhima that referenced this issue Sep 19, 2016
fix(purchase): remove cellNav from purchase grid
2961292 
This commit removed the ui-grid-cellNav from the purchase grid.  It also
uses a `ui-select` instead of a `typeahead` for the supplier search box.

Closes Third-Culture-Software#726.
@jniles jniles mentioned this issue Sep 19, 2016
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @DedrickEnc