Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Patient Invoice Form needs loading button #1366

Closed
jniles opened this issue Mar 19, 2017 · 3 comments
Closed

(refactor) Patient Invoice Form needs loading button #1366

jniles opened this issue Mar 19, 2017 · 3 comments
Assignees
@jniles
Labels
Refactor

Comments

@jniles
Copy link
Collaborator

jniles commented Mar 19, 2017

The Patient Invoice Form does not have a bhLoadingButton. This causes users to click the button multiple times and query the database several times for the same invoice payment. Most other forms use a loading button to both provide feedback to the user and to provide security by disabling submission. A bhLoadingButton should be placed on the Patient Invoice module as soon as possible.
@sfount
Copy link
Contributor

sfount commented Mar 20, 2017

To add to this I don't think it should be possible to clear the form whilst the form is trying to submit to the server. The loading process here should also block the cancel button from being pressed.

@jniles
Copy link
Collaborator Author

jniles commented Mar 20, 2017

I agree. A fieldset can be used to disable the whole thing.

Is someone working on this? I've already written a patch for Vanga that needs to be updated to latest standards, but if no one else is working on it, I'll take it.

@sfount
Copy link
Contributor

sfount commented Mar 20, 2017

No one else has taken this yet - @jniles if you've already done a patch it would probably be fastest for you to take it. Even if you just want to submit your patch branch and we can improve it through code review.

jniles pushed a commit to jniles/bhima that referenced this issue Mar 20, 2017
fix(invoice): disable buttons on submit
d71c4c6 
This commit refactors the Patient Invoice module to disable the submit
button and clear button when the user submits an invoice.  It should
help reduce problems due to users absent-mindedly overloading the
database.

Closes Third-Culture-Software#1366.
@jniles jniles mentioned this issue Mar 20, 2017
Merged
jniles pushed a commit to jniles/bhima that referenced this issue Mar 20, 2017
fix(invoice): disable buttons on submit
70d075c 
This commit refactors the Patient Invoice module to disable the submit
button and clear button when the user submits an invoice.  It should
help reduce problems due to users absent-mindedly overloading the
database.

Closes Third-Culture-Software#1366.
jniles pushed a commit to jniles/bhima that referenced this issue Mar 21, 2017
fix(invoice): disable buttons on submit
1503de3 
This commit refactors the Patient Invoice module to disable the submit
button and clear button when the user submits an invoice.  It should
help reduce problems due to users absent-mindedly overloading the
database.

Closes Third-Culture-Software#1366.
jniles pushed a commit that referenced this issue Mar 21, 2017
@jniles
fix(invoice): disable buttons on submit
9e23c63 
This commit refactors the Patient Invoice module to disable the submit
button and clear button when the user submits an invoice.  It should
help reduce problems due to users absent-mindedly overloading the
database.

Closes #1366.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount