(refactor) Posting Journal Editing #1500
Labels
Comments
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Apr 13, 2017
This commit introduces the typeahead editing feature for accounts. This feature allows an accountant to type in the account name or label and select the correct account from a dropdown list. Partially addresses IMA-WorldHealth#1500.
jniles
pushed a commit
to jniles/bhima
that referenced
this issue
Apr 13, 2017
This commit introduces the typeahead editing feature for accounts. This feature allows an accountant to type in the account name or label and select the correct account from a dropdown list. Partially addresses IMA-WorldHealth#1500.
4 tasks
ghost
pushed a commit
that referenced
this issue
Apr 14, 2017
…, r=<try> refactor(journal): posting journal account editing This PR implements posting journal account editing with a dropdown. It should be helpful in finding and linking accounts correctly. The editor is a dropdown based off the MIT-licensed [ui-grid-edit-datepicker](https://github.com/Joiler/ui-grid-edit-datepicker). This helped me figure out how to properly hook up the events for onEdit and on $destroy, as well as detecting external clicks. Partially addresses #1500. --- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
ghost
pushed a commit
that referenced
this issue
Apr 14, 2017
…, r=<try> refactor(journal): posting journal account editing This PR implements posting journal account editing with a dropdown. It should be helpful in finding and linking accounts correctly. The editor is a dropdown based off the MIT-licensed [ui-grid-edit-datepicker](https://github.com/Joiler/ui-grid-edit-datepicker). This helped me figure out how to properly hook up the events for onEdit and on $destroy, as well as detecting external clicks. Partially addresses #1500. --- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
ghost
pushed a commit
that referenced
this issue
Apr 14, 2017
…, r=<try> refactor(journal): posting journal account editing This PR implements posting journal account editing with a dropdown. It should be helpful in finding and linking accounts correctly. The editor is a dropdown based off the MIT-licensed [ui-grid-edit-datepicker](https://github.com/Joiler/ui-grid-edit-datepicker). This helped me figure out how to properly hook up the events for onEdit and on $destroy, as well as detecting external clicks. Partially addresses #1500. --- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
jniles
added a commit
that referenced
this issue
Apr 15, 2017
* feat(journal): edit accounts via typeahead This commit introduces the typeahead editing feature for accounts. This feature allows an accountant to type in the account name or label and select the correct account from a dropdown list. Partially addresses #1500. * fix(journal): filter title accounts from dropdown This commit filters title accounts from the journal selection dropdown to prevent users from accidentally submitting title accounts instead of the correct account.
4 tasks
ghost
pushed a commit
that referenced
this issue
Apr 18, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
ghost
pushed a commit
that referenced
this issue
Apr 19, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
ghost
pushed a commit
that referenced
this issue
Apr 19, 2017
…l, r=jniles fix(journal): ensure that data callbacks disable cellNav This commit makes sure that the Posting Journal's dataChange callbacks are run after the columns are modified. Closes #1495. Addresses #1500. ---- Thank you for contributing! Before submitting this pull request, please verify that you have: - [x] Run your code through ESLint. [Check out our styleguide](https://github.com/IMA-WorldHealth/bhima-2.X/blob/master/docs/STYLEGUIDE.md). - [x] Run integration tests. - [x] Run end-to-end tests. - [x] Accurately described the changes your are making in this pull request. For a more detailed checklist, [see the official review checklist](https://docs.google.com/document/d/1nupLVLRXgSZJQo_acLgrwvPnN8RukfSiwRhSToj81uU/pub) that this PR will be evaluated against. Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!
6 tasks
bors bot
added a commit
that referenced
this issue
Sep 25, 2017
2085: refactor: Posting Journal and Associated Tools r=mbayopanda a=jniles This Pull Request finalizes the refactor of the Posting Journal and associated modules. The commit history contains a full list of changes. In brief: 1. Editing has been moved out into a modal. By breaking out the editing code, the complexity of the Posting Journal is reduced. It also enforces editing a single transaction at a time. 2. The Trial Balance has moved into Stored Procedures. This separates the JS code from the SQL code and speeds up the execution of the Trail Balance slightly. 3. The Trial Balance no longer reloads data between `$state` changes. The modal is much more snappy than previous. 4. Links to the receipts/documents/patients associated with each transaction are embedded in the Posting Journal. This makes it easy to find the details associated with a given transaction. 5. The Posting Journal is able to load "posted" transactions. To accommodate this, the Posting Journal footer has been improved to show the number of unposted or posted transactions. Additionally, the "Posted Journal" module has been removed. There have been a number of miscellaneous bug fixes addressed as well. As with any change, this may introduce new bugs specific to the changes listed above. Partially addresses #1432. Closes #1034. Closes #1163. Closes #1402. Closes #1500. Closes #1640. Closes #1659. Closes #1716. Closes #1717. Closes #1724. Closes #1832. Closes #1839. Closes #1921. Closes #1928. Closes #1934. Closes #1943. Closes #1944. Closes #1948. Closes #1950. Closes #1961. Closes #2031. Closes #2041. --- ### TODO Before Merge - [x] Ensure all keys are translated into both French and English - [x] Ensure tests pass - [x] Make sure all filters/links work on Posting Journal page. - [x] Make sure all filters/links work on the Trial Balance - [x] Ensure all editors work as expected. - [x] Ensure that new code passes lint checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Editing in the Posting Journal is fairly immature. The following changes are needed to make sure that users can easily, effectively, and correctly use the Posting Journal:
The text was updated successfully, but these errors were encountered: