Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(proposal) Make the patient financial history easily available #1921

Closed
sfount opened this issue Aug 2, 2017 · 2 comments · Fixed by #2085
Closed

(proposal) Make the patient financial history easily available #1921

sfount opened this issue Aug 2, 2017 · 2 comments · Fixed by #2085

Comments

@sfount
Copy link
Contributor

sfount commented Aug 2, 2017

Our patient financial history report ties together all of the financial entities in BHIMA that relate to a patient. Primarily invoices and cash payments but also vouchers that reference the patient.

Right now it is hidden in the patient overview module: I propose we make this easily accessible to the user in a number of ways:

  1. Directly link the patient financial report anywhere that a patient human readable ID is used. This would use the work done in Link entities from report #1886 and (fix) Reference links corner cases #1916.
    (the patient card could also be linked in a multi-part component. For example PA.HSP.100 [C]
  2. Register it a BHIMA report just like the account statement - the user would be able to select a patient and preview and save the report.

Additionally it would be good to treat this as an up to date report and test the data values produced by the financial history.
@jniles
Copy link
Collaborator

jniles commented Aug 2, 2017

I think it would be surprising to click the PA.HSP.100 link and find a financial history of a patient. Potentially it makes sense on the ledger-style modules (Journal, GL, Account Statement), but on the Patient Registry it feels like it should produce either their information page or their card.

What do you think?

@sfount
Copy link
Contributor Author

sfount commented Aug 2, 2017

Agreed this would only be from financial tool modules - the patient registry could continue as it is right now.

@jniles jniles mentioned this issue Aug 9, 2017
Closed
@jniles jniles mentioned this issue Sep 20, 2017
Merged
6 tasks
bors bot added a commit that referenced this issue Sep 25, 2017
@bors
Merge #2085
afc9ee2 
2085: refactor: Posting Journal and Associated Tools r=mbayopanda a=jniles

This Pull Request finalizes the refactor of the Posting Journal and associated modules.  The commit history contains a full list of changes.  In brief:
 1. Editing has been moved out into a modal.  By breaking out the editing code, the complexity of the Posting Journal is reduced.  It also enforces editing a single transaction at a time.
 2. The Trial Balance has moved into Stored Procedures.  This separates the JS code from the SQL code and speeds up the execution of the Trail Balance slightly.
 3. The Trial Balance no longer reloads data between `$state` changes.  The modal is much more snappy than previous.
 4. Links to the receipts/documents/patients associated with each transaction are embedded in the Posting Journal.  This makes it easy to find the details associated with a given transaction.
 5. The Posting Journal is able to load "posted" transactions.  To accommodate this, the Posting Journal footer has been improved to show the number of unposted or posted transactions.  Additionally, the "Posted Journal" module has been removed.

There have been a number of miscellaneous bug fixes addressed as well.  As with any change, this may introduce new bugs specific to the changes listed above.

Partially addresses #1432.

Closes #1034.
Closes #1163.
Closes #1402.
Closes #1500.
Closes #1640.
Closes #1659.
Closes #1716.
Closes #1717.
Closes #1724.
Closes #1832.
Closes #1839.
Closes #1921.
Closes #1928.
Closes #1934.
Closes #1943.
Closes #1944.
Closes #1948.
Closes #1950.
Closes #1961.
Closes #2031.
Closes #2041.

---

### TODO Before Merge
 - [x] Ensure all keys are translated into both French and English
 - [x] Ensure tests pass
 - [x] Make sure all filters/links work on Posting Journal page.
 - [x] Make sure all filters/links work on the Trial Balance
 - [x] Ensure all editors work as expected.
 - [x] Ensure that new code passes lint checks.
@bors bors bot closed this as completed in #2085 Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Posting Journal and Associated Tools Third-Culture-Software/bhima
2 participants
@jniles @sfount