proposal: rename "Posting Journal" into "Journal" #2031
Labels
Comments
jniles
added a commit
that referenced
this issue
Sep 22, 2017
This commit renames the Posting Journal and subsequent translations to "Journal". It also removes "Posted Journal" from the database. Closes #2031
6 tasks
jniles
added a commit
that referenced
this issue
Sep 22, 2017
This commit renames the Posting Journal and subsequent translations to "Journal". It also removes "Posted Journal" from the database. Closes #2031
jniles
added a commit
that referenced
this issue
Sep 25, 2017
This commit renames the Posting Journal and subsequent translations to "Journal". It also removes "Posted Journal" from the database. Closes #2031
bors bot
added a commit
that referenced
this issue
Sep 25, 2017
2085: refactor: Posting Journal and Associated Tools r=mbayopanda a=jniles This Pull Request finalizes the refactor of the Posting Journal and associated modules. The commit history contains a full list of changes. In brief: 1. Editing has been moved out into a modal. By breaking out the editing code, the complexity of the Posting Journal is reduced. It also enforces editing a single transaction at a time. 2. The Trial Balance has moved into Stored Procedures. This separates the JS code from the SQL code and speeds up the execution of the Trail Balance slightly. 3. The Trial Balance no longer reloads data between `$state` changes. The modal is much more snappy than previous. 4. Links to the receipts/documents/patients associated with each transaction are embedded in the Posting Journal. This makes it easy to find the details associated with a given transaction. 5. The Posting Journal is able to load "posted" transactions. To accommodate this, the Posting Journal footer has been improved to show the number of unposted or posted transactions. Additionally, the "Posted Journal" module has been removed. There have been a number of miscellaneous bug fixes addressed as well. As with any change, this may introduce new bugs specific to the changes listed above. Partially addresses #1432. Closes #1034. Closes #1163. Closes #1402. Closes #1500. Closes #1640. Closes #1659. Closes #1716. Closes #1717. Closes #1724. Closes #1832. Closes #1839. Closes #1921. Closes #1928. Closes #1934. Closes #1943. Closes #1944. Closes #1948. Closes #1950. Closes #1961. Closes #2031. Closes #2041. --- ### TODO Before Merge - [x] Ensure all keys are translated into both French and English - [x] Ensure tests pass - [x] Make sure all filters/links work on Posting Journal page. - [x] Make sure all filters/links work on the Trial Balance - [x] Ensure all editors work as expected. - [x] Ensure that new code passes lint checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since we have deprecated the "Posted Journal" and moved it's view into a filter on the regular "Posting Journal", I think it might reduce a lot of confusion by renaming the "Posting Journal" to the "Journal". It will be easier to refer to, and more semantically correct since we now allow viewing of posted records in the journal.
References work done in refactor-journal-tools.
\cc @IMA-WorldHealth/bhima-core what do you all think?
The text was updated successfully, but these errors were encountered: