Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grade_id into grade_uuid #2208

Closed
jniles opened this issue Oct 16, 2017 · 1 comment
Closed

Make grade_id into grade_uuid #2208

jniles opened this issue Oct 16, 2017 · 1 comment

Comments

@jniles
Copy link
Collaborator

jniles commented Oct 16, 2017

See the discussion on #2191 (comment)

The employee table has a column called grade_uuid that references the column grade.uuid. It is quite confusing. All uuid columns should be suffixed with _uuid to help programmers know that they are dealing with a binary uuid on the underlying table.

Someone should change this column to be grade_uuid and update the associated tests.

@jniles
Copy link
Collaborator Author

jniles commented Oct 19, 2017

I'll take this one.

jniles added a commit to jniles/bhima that referenced this issue Oct 19, 2017
This commit renames the "grade_id" column to "grade_uuid" in reflection
of it's underlying uuid representation.  The two commands that were run
were:
```sh
find ./client/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./server/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
```

Closes Third-Culture-Software#2208.
jniles added a commit to jniles/bhima that referenced this issue Oct 19, 2017
This commit renames the "grade_id" column to "grade_uuid" in reflection
of it's underlying uuid representation.  The three commands that were run
were:
```sh
find ./client/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./server/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./test/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
```

Closes Third-Culture-Software#2208.
jniles added a commit to jniles/bhima that referenced this issue Oct 23, 2017
This commit renames the "grade_id" column to "grade_uuid" in reflection
of it's underlying uuid representation.  The three commands that were run
were:
```sh
find ./client/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./server/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./test/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
```

Closes Third-Culture-Software#2208.
jniles added a commit to jniles/bhima that referenced this issue Oct 24, 2017
This commit renames the "grade_id" column to "grade_uuid" in reflection
of it's underlying uuid representation.  The three commands that were run
were:
```sh
find ./client/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./server/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./test/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
```

Closes Third-Culture-Software#2208.
bors bot added a commit that referenced this issue Oct 24, 2017
2216: fix(employee): rename grade_id to grade_uuid r=lomamech a=jniles

This commit renames the "grade_id" column to "grade_uuid" in reflection
of it's underlying uuid representation.  The three commands that were run
were:
```sh
find ./client/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./server/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
find ./test/ -type f | xargs sed -i  's/grade_id/grade_uuid/g'
```

Partially addressed #342.

Closes #2208.
@bors bors bot closed this as completed in #2216 Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant