Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Testing) Use ng-describe to reduce boilerplate in unit tests #252

Closed
1 task
sfount opened this issue Apr 1, 2016 · 4 comments
Closed
1 task

(Testing) Use ng-describe to reduce boilerplate in unit tests #252

sfount opened this issue Apr 1, 2016 · 4 comments
Labels
Refactor

Comments

@sfount
Copy link
Contributor

sfount commented Apr 1, 2016

Unit tests have recently been (will be) added in #250. NgDescribe will allow us to remove a great deal of the unit test boilerplate.

  • Write full description of the benefits of ngDescribe.
@sfount sfount added the Refactor label Apr 1, 2016
@sfount sfount added this to the 2.x Process milestone Apr 1, 2016
@jniles
Copy link
Collaborator

jniles commented Apr 1, 2016

Here's a link to the github site, and some examples. It looks useful to me!

@jniles
Copy link
Collaborator

jniles commented May 12, 2016

As we currently have several more unit tests, one (SessionService) that wraps critical application functionality, I think now a developer should look into this as an testing tool. @sfount, what do you think?

@jniles
Copy link
Collaborator

jniles commented Jun 24, 2016

@DedrickEnc, these ideas might help you with #510. If you want to investigate both at the same time, feel free!

@jniles
Copy link
Collaborator

jniles commented Jul 2, 2018

Note - ng-describe doesn't look like it is maintained anymore. We seem to be getting by fine with our current implementation.

@jniles jniles closed this as completed Jul 2, 2018
bors bot added a commit that referenced this issue Oct 23, 2018
@bors @greenkeeper
Merge #3280
0dca71c 
3280: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.104.1` to `1.104.2`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v1.104.2</summary>

<h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.104.1...v1.104.2">1.104.2</a> (2018-10-23)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>don't print vulnerable paths count for docker tests (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/eb06722">eb06722</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 3 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/be98a50cbeab919f0f1f72f876b09d38ba658773"><code>be98a50</code></a> <code>Merge pull request #252 from snyk/feat/rm-num-of-vuln-paths</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/76eda06f09759ba17aa4b8e87fdf286d147d4aee"><code>76eda06</code></a> <code>chore: extened the vuln ignore of nyc</code></li>
<li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/eb067224b62e4ab91cf0cd4fe54f2f5e77841a70"><code>eb06722</code></a> <code>fix: don't print vulnerable paths count for docker tests</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/146185cfc546cb76c1a765d4fcefd62f5ce4a6e1...be98a50cbeab919f0f1f72f876b09d38ba658773">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount