Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter toggle button into a component #2523

Closed
jniles opened this issue Feb 8, 2018 · 0 comments · Fixed by #2545
Closed

Make filter toggle button into a component #2523

jniles opened this issue Feb 8, 2018 · 0 comments · Fixed by #2545
Assignees
Labels

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 8, 2018

We use this code everywhere:

      <div class="toolbar-item">
        <button
          type="button"
          ng-click="ConfigurationCtrl.toggleFilter()"
          data-method="filter"
          class="btn btn-default"
          ng-class="{ 'btn-info' : ConfigurationCtrl.filterEnabled }">
          <i class="fa fa-filter"></i>
        </button>
      </div>

It is ripe for a component to standardize its look and operation. Something like:

<bh-filter-toggle on-toggle="ConfigurationCtrl.toggleFilter()"></bh-filter-toggle>
@jniles jniles added the Refactor label Feb 8, 2018
@jeremielodi jeremielodi self-assigned this Feb 16, 2018
bors bot added a commit that referenced this issue Feb 22, 2018
2545: feat(component) filter toggle button r=jniles a=jeremielodi

closes #2523
bors bot added a commit that referenced this issue Feb 22, 2018
2545: feat(component) filter toggle button r=jniles a=jeremielodi

closes #2523

2548: feat(journal): add extra search parameters r=jniles a=jniles

This commit adds the following search parameters to the Posting Journal:
 1. `comment` - fuzzy searches the "comment" column
 2. `hrRecord` - searches the "record" column
 3. `hrEntity` - searches the "entity" column
 4. `hrReference` - searches the "reference" column

Closes #2547.
bors bot added a commit that referenced this issue Feb 22, 2018
2545: feat(component) filter toggle button r=jniles a=jeremielodi

closes #2523
bors bot added a commit that referenced this issue Feb 22, 2018
2545: feat(component) filter toggle button r=jniles a=jeremielodi

closes #2523
@bors bors bot closed this as completed in #2545 Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants