Ensure all uuid fields are named with _uuid suffix
#342
Labels
Comments
jniles
changed the title
_uuid_uuid suffix
bors bot
added a commit
that referenced
this issue
Oct 24, 2017
2216: fix(employee): rename grade_id to grade_uuid r=lomamech a=jniles This commit renames the "grade_id" column to "grade_uuid" in reflection of it's underlying uuid representation. The three commands that were run were: ```sh find ./client/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' find ./server/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' find ./test/ -type f | xargs sed -i 's/grade_id/grade_uuid/g' ``` Partially addressed #342. Closes #2208.
bors bot
added a commit
that referenced
this issue
Jan 27, 2019
3561: Update snyk to the latest version 🚀 r=jniles a=greenkeeper[bot] ## The dependency [snyk](https://github.com/snyk/snyk) was updated from `1.122.3` to `1.122.4`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v1.122.4</summary> <h2><a href="https://urls.greenkeeper.io/snyk/snyk/compare/v1.122.3...v1.122.4">1.122.4</a> (2019-01-26)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>docs:</strong> add missing composer.lock file (<a href="https://urls.greenkeeper.io/snyk/snyk/commit/f66d1b9">f66d1b9</a>)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 6 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/5160c558cc8e3f06ddbfeaed8a6f6df749bf1e8b"><code>5160c55</code></a> <code>Merge pull request #346 from snyk/lirantal-composer-lockfile-help</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/f66d1b981f40dfae06e611e7bc09e05f6799682d"><code>f66d1b9</code></a> <code>fix(docs): add missing composer.lock file</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/e98739a9a4067236e6b758b55b494973879189e2"><code>e98739a</code></a> <code>Merge pull request #318 from snyk/refactor/commands-test</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/2080fa0cd1e2b860c4730aa65cd94c3af1faf571"><code>2080fa0</code></a> <code>refactor: test command rewritten to TS</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/7a4a91563e26d6e197f7894312ebec1505bbd0c6"><code>7a4a915</code></a> <code>Merge pull request #342 from snyk/chore/remove-build-from-toc</code></li> <li><a href="https://urls.greenkeeper.io/snyk/snyk/commit/6d2feb06f18638ae50061ed533b523e888135216"><code>6d2feb0</code></a> <code>chore: remove build from TOC</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/snyk/snyk/compare/6b07600cf7d935bb9a022fba1a8c8486db051878...5160c558cc8e3f06ddbfeaed8a6f6df749bf1e8b">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In order to clarify our database practices, I propose that all fields that are binary uuids be named with the suffix
_uuidif the field name is notuuid.One example of this is
location_id, which is a uuid and would make far better sense if it were namedlocation_uuid. I propose that someone analyze the database to see if there are any other fields such as this, and refactor them as necessary.@IMA-WorldHealth/local-contributors this probably should be discussed. Any opposing thoughts?
The text was updated successfully, but these errors were encountered: