Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build minification no longer works on master. #447

Closed
jniles opened this issue May 27, 2016 · 0 comments · Fixed by #449
Closed

Build minification no longer works on master. #447

jniles opened this issue May 27, 2016 · 0 comments · Fixed by #449
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented May 27, 2016 •
edited
Loading

The application build process (gulp build) fails with a fatal error when the build is minified.

Steps to reproduce:

  1. Change the variable "UGLIFY" in gulpfile.js to true.
  2. Run ./node_modules/.bin/gulp build
  3. Check the console for errors.
@jniles jniles added the Bug label May 27, 2016
jniles referenced this issue in jniles/bhima May 27, 2016
@jniles
fix(gulp): remove es6 arrow functions to minify
b88bdfa 
This commit fixes gulp-build with minification by removing the ES6 fat
arrow functions from the client.  It turns out these break the `uglify`
compiler.

It also turns on minification by default.  This can be switched off if
it takes too long to run tests.

Closes #447.
@jniles jniles mentioned this issue May 27, 2016
Merged
4 tasks
jniles referenced this issue in jniles/bhima May 27, 2016
@jniles
fix(gulp): remove es6 arrow functions to minify
999b413 
This commit fixes gulp-build with minification by removing the ES6 fat
arrow functions from the client.  It turns out these break the `uglify`
compiler.

It also turns on minification by default.  This can be switched off if
it takes too long to run tests.

Closes #447.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gulp): remove es6 arrow functions to minify jniles/bhima
1 participant
@jniles