Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(component) bhInfo for showing popover information #525

Closed
jniles opened this issue Jun 22, 2016 · 1 comment
Closed

(component) bhInfo for showing popover information #525

jniles opened this issue Jun 22, 2016 · 1 comment

Comments

@jniles
Copy link
Collaborator

jniles commented Jun 22, 2016

In several places we have begun using popovers to show additional information that would be hidden from the user normally. Some examples of this are debtor groups, patient invoicing, and purchase orders.

Observation
Every single popover looks like this:

<span
   class="text-info fa fa-info-circle"
   uib-popover-template="'typePopover.tmpl.html'"
   popover-placement="right"
   popover-append-to-body="true"
   popover-trigger="mouseenter">
</span>

This is mostly repeated code.

Proposal
I propose we make a new component called bhInfo with the following signature:

<bh-info template="some/url" direction="right"></bh-info>

That would embed the icon and popover automatically into the page. This would speed up development of modules by a bit and encourage use of popovers.

@mbayopanda
Copy link
Collaborator

👍

@jniles jniles added this to the Future milestone Jun 23, 2016
jniles referenced this issue in jniles/bhima Jun 28, 2016
This commit creates a bhInfo component that is simply a wrapper for
popovers.  Since this is a component, these popovers cannot have any
knowledge of their parent scope.  This component is ideal for
informational popovers that only contain $translate filters.

Closes #525.
jniles referenced this issue in jniles/bhima Jun 28, 2016
This commit creates a bhInfo component that is simply a wrapper for
popovers.  Since this is a component, these popovers cannot have any
knowledge of their parent scope.  This component is ideal for
informational popovers that only contain $translate filters.

Closes #525.
sfount pushed a commit that referenced this issue Jun 29, 2016
This commit creates a bhInfo component that is simply a wrapper for
popovers.  Since this is a component, these popovers cannot have any
knowledge of their parent scope.  This component is ideal for
informational popovers that only contain $translate filters.

Closes #525.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants