fix(invoices): only show item error if configured #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the global error message is only shown if there is no sales account _after_ the item has been configured. Previously, this resulted in showing large error messages during perfectly normal operation. Closes Third-Culture-Software#1046.
jniles
force-pushed
the
fix-patient-invoice-fatal-errors
branch
from
5c08e0c
to
a995858
Compare
sfount
approved these changes
Dec 15, 2016
| if (!row._hasSalesAccount) { | ||
| // this sets the global configuration error if there is no sales account | ||
| // and the row has already been configured. | ||
| if (row._initialised && !row._hasSalesAccount) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the global error message is only shown if there
is no sales account after the item has been configured. Previously,
this resulted in showing large error messages during perfectly normal
operation.
Closes #1046.
Fig 1: Hidden Errors when Items not Configured
Fig 2: Visible Errors when Items missing Sales Account)
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!