Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix journal edit errors #1561

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Fix journal edit errors #1561

merged 1 commit into from
Apr 27, 2017

Conversation

mbayopanda
Copy link
Collaborator

This PR fix these issues : #1536 #1560 #1558

@mbayopanda mbayopanda requested a review from jniles April 25, 2017 14:27
@mbayopanda mbayopanda requested review from sfount and removed request for jniles April 26, 2017 09:03
jniles
jniles approved these changes Apr 27, 2017
View reviewed changes
Copy link
Collaborator

@jniles jniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really simple fixes, looks like an excellent PR. Great work! 👍

client/src/js/services/grid/TransactionService.js
@@ -345,6 +345,11 @@ function TransactionService($timeout, util, uiGridConstants, bhConstants, Notify
ERR_DEB_CRED_NOT_NULL = 'POSTING_JOURNAL.ERRORS.DEB_CRED_NOT_NULL',
ERR_CREDITED_DEBITED = 'POSTING_JOURNAL.ERRORS.CREDITED_DEBITED';

// If the transaction has 0 line
if (numberOfLine === 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch.

server/controllers/finance/journal/index.js
@@ -374,6 +374,10 @@ function transformColumns(rows, newRecord) {
delete row.account_number;
}

if (row.account_name) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch.

@jniles jniles merged commit de7451a into Third-Culture-Software:master Apr 27, 2017
@mbayopanda mbayopanda deleted the fix_journal_edit branch August 22, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jniles jniles jniles approved these changes

@sfount sfount Awaiting requested review from sfount

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbayopanda @jniles