feat(account): report opening balances #1644
Conversation
|
@mbayopanda, can you give me a review of this code? |
|
@jniles I will review this code as soon as possible today. |
jniles
force-pushed
the
feature-account-report-beginning-balances
branch
2 times, most recently
from
9116551
to
6e2264e
Compare
| .then(periodId => | ||
| getComputedAccountBalanceUntilDate(accountId, date, periodId) | ||
| ) | ||
| .then(runningPeriodBalance => balance + runningPeriodBalance); |
There was a problem hiding this comment.
These calculations are used here in financial reports - are they ever rounded? It looks like they would be subject to Javascript's rounding floating point issues?
There was a problem hiding this comment.
In theory, the currency filter takes care of that. However, I could make them into fixed numbers if you think it's best.
| @@ -31,6 +31,8 @@ let frFileMissList = []; | |||
|
|
|||
| const jsonFiles = buildJsonFileArray(); | |||
|
|
|||
| const notSwapFile = (fname) => !fname.includes('.swp'); | |||
There was a problem hiding this comment.
Nice fix 👍 . Truly professional swap file abusers end up with .sw* to the ends of the earth. This should work well though.
There was a problem hiding this comment.
I don't actually think this fix works, actually. You can test it out. I had limited success.
This commit builds a new feature for accounts that can discern their opening balance (from the General Ledger) given a date and account id. The major changes have been added in an "AccountExtra" file that should be merged into accounts/index.js as soon as the major refactoring is finished. This PR consists of two parts: the updated account report that now contains an opening balance and the utility to find the opening balance give a particular date and account_id. Closes Third-Culture-Software#1611. Closes Third-Culture-Software#1636.
jniles
force-pushed
the
feature-account-report-beginning-balances
branch
from
6e2264e
to
8e5ad48
Compare
| .then(periodId => | ||
| getComputedAccountBalanceUntilDate(accountId, date, periodId) | ||
| ) | ||
| .then(runningPeriodBalance => (balance + runningPeriodBalance).toFixed(4)); |
There was a problem hiding this comment.
This should work well for now! It would be good to research a library like BigNumber to make this a standard for reports going forward.
This commit builds a new feature for accounts that can discern their opening balance (from the
General Ledger) given a date and account id. The major changes have been added in an "AccountExtra"
file that should be merged into accounts/index.js as soon as the major refactoring is finished.
This PR consists of two parts: the updated account report that now
contains an opening balance and the utility to find the opening balance
give a particular date and account_id.
Closes #1611. Closes #1636.
Thank you for contributing!
Before submitting this pull request, please verify that you have:
For a more detailed checklist, see the official review checklist that this PR will be evaluated against.
Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!