Prevent $state.current to become empty afer refresh #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lomamech
force-pushed
the
fixRefreshUpdatePage
branch
2 times, most recently
from
891c8df
to
5bb1ee8
Compare
- User Management - Account Edit - Billing Sercice Updare - Inventory actions modal
- Account Management - Inventory`
mbayopanda
reviewed
May 30, 2017
| @@ -30,6 +30,9 @@ angular.module('bhima.routes') | |||
| }) | |||
| .state('inventory.create', { | |||
| url : '/create', | |||
| params : { | |||
| creating : { value : true } | |||
| }, | |||
There was a problem hiding this comment.
What is the need of value ? What do you think about :
params : {
creating : true,
},
There was a problem hiding this comment.
It makes it possible to differentiate the creation of the update, to consider only the present of the $state.params.uuid was not sufficient especially when one refreshed the browser
lomamech
force-pushed
the
fixRefreshUpdatePage
branch
from
5bb1ee8
to
b87a256
Compare
|
Seems like this got the green light! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent $state.current to become empty afer refresh
closes #1345