CHORE(db): implement invoicing schemas #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the following schemas: 1. billing_service 2. subsidy 3. discount and all associated linker tables. These build correctly, but require an API interface to prove their usefulness.
This commit repairs invalid foreign key constraints in synt.sql that prevented the new schema definitions from being built properly.
This commit skips the posting journal tests until the new posting journal interface can be developed and used. These tests should be uncommented and behaved as previously when the routes are in place.
jniles
force-pushed
the
feature-invoice-schemas
branch
from
d1ad5f7
to
fe3565b
Compare
|
@sfount, I've rebased this to account for the cash API. Would you mind reviewing it and merging the code in? |
|
@jniles Will review this morning. |
sfount
added a commit
that referenced
this pull request
Jan 19, 2016
CHORE(db): implement invoicing schemas
bors bot
added a commit
that referenced
this pull request
Dec 15, 2017
2320: Update pump to the latest version 🚀 r=jniles a=greenkeeper[bot] ## Version **2.0.0** of [pump](https://github.com/mafintosh/pump) was just published. <table> <tr> <th align=left> Dependency </td> <td> pump </td> </tr> <tr> <th align=left> Current Version </td> <td> 1.0.3 </td> </tr> <tr> <th align=left> Type </td> <td> devDependency </td> </tr> </table> The version **2.0.0** is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. It might be worth looking into these changes and trying to get this project onto the latest version of pump. If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update. --- <details> <summary>Commits</summary> <p>The new version differs by 2 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/mafintosh/pump/commit/e3d0c444ceef59ff694c753303a35052e60b5186"><code>e3d0c44</code></a> <code>2.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mafintosh/pump/commit/0c507239810b1e7f79ba0927ef78e90dd3a529e5"><code>0c50723</code></a> <code>(breaking) remove return of pipeline - closes #9 (#18)</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/mafintosh/pump/compare/28557d8349d8e3b6878f9955d28b4a52c6a44de3...e3d0c444ceef59ff694c753303a35052e60b5186">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the following database schemas:
billing_servicesubsidydiscountand all associated linker tables. These tables are all prerequisites to performing a patient invoice operation.
NOTE This PR turns off (via
it.skip()) some of the sale API tests since the posting journal no longer properly looks up sale subsidies. A separate PR building the Sale-Posting Journal interface should turn these back on before being merged into master.